macos: wrap spatial goto around edges#12615
Closed
tautik wants to merge 1 commit intoghostty-org:mainfrom
Closed
Conversation
shift the current slot by one full grid in the opposite direction and reuse the existing nearest-distance logic, mirroring the gtk approach in ghostty-org#10811. fixes ghostty-org#8406
Contributor
|
Hi @tautik, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8406. mirrors #10811 for macos.
spatial split navigation now wraps at the edges. first attempts the
nearest target using the existing slot geometry. if there is no
candidate in the requested direction, synthesizes a wrapped target
by shifting the current slot by one full grid in the opposite
direction and reuses the same nearest-distance logic.
verified locally: 8 new tests pass, full GhosttyTests suite green
(macos/build.nu --action test, xcode 26.4.1).
ai-assistance: partial use of claude code during implementation; i
reviewed and understand the change.