Skip to content

Document the private-skills credential contract of the kagent API v2 line: the tenant's Secret in the kagent namespace, no Harness credential, where the token is visible; verify the pinned kagent-crds serve credentialRef (D8/D17) #369

Description

@teemow

Part of epic giantswarm/giantswarm#37705 (kagent API v2 migration); the consequence of the spike giantswarm/giantswarm#37321 for this chart. Siblings: giantswarm/agent (the chart value), giantswarm/agent-manager, giantswarm/backstage.

Problem

The spike decided the credential for private skill repositories under kagent API v2: a per-source credential on the AgentTemplate (skills[].source.git.credentialRef, carried in the kagent line — giantswarm/kagent-upstream#13), not an ambient credential on the platform Harness. That settles what this chart does and does not do, and nothing says it yet:

Proposed solution

Documentation and a guard, no rendering change:

  • README (the kagent API v2 section): "Private skill repositories" — who provisions the Secret, where (kagent), its shape and label, rotation (contents, never the name), what a missing Secret and a wrong token look like on the AgentTemplate (ResolvedRefs=False vs Ready=False ActorTemplatePending), and where the token is visible.
  • A comment on the connectivity Harness values (kagent.harness) saying the Harness carries no credential and why.
  • tests/verify-kagent-crds.py (or its successor) asserts the pinned kagent-crds serve skills[].source.git.credentialRef once the pin moves to the release that carries it, so a re-pin below it fails the verify instead of pruning the field silently.

Acceptance criteria

  • README documents the credential contract and the Harness's non-involvement.
  • The CRD verify asserts credentialRef on the pinned kagent-crds (added with the re-pin that first carries it).
  • No change to the rendered Harness objects (make verify-kagent-harness unchanged).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions