fix blank tokenomics page, dead help cards, mobile-nav a11y, missing metadata - #150
Open
prerevenuefable wants to merge 5 commits into
Open
fix blank tokenomics page, dead help cards, mobile-nav a11y, missing metadata#150prerevenuefable wants to merge 5 commits into
prerevenuefable wants to merge 5 commits into
Conversation
/tokenomics rendered only the nav bar. Add minimal content: $WORK description, token address, and links to the tokenomics docs, DexScreener and CoinGecko (all taken from docs.gib.work), plus the footer and page metadata.
The three cards under "Get help from an expert" didn't link anywhere. Open Source Bounty and Simple Task now go to the live create flows on app.gib.work; Services goes to the app (no services route exists there yet). All three images had alt="Open Source Bounty" copy-pasted; the hero dashboard screenshot had an empty alt.
The mobile menu overlay had no dialog role, the hamburger and close buttons no accessible names, and Escape didn't close it. Add role=dialog/aria-modal, aria-label + aria-expanded/aria-controls on the toggle, move focus to the close button on open and back on close, and close on Escape. Icon-only social links in the nav and footer get aria-labels too.
…e import Social embeds had no twitter card and no metadataBase for resolving relative og URLs. The sitemap listed one URL with lastmod 2024-08-28; add /tokenomics and update it. hero.tsx imported Clipboard from flowbite-react for a commented-out block only, pulling the library into the client bundle for nothing.
|
@prerevenuefable is attempting to deploy a commit to the gibwork Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four broken states, all reproducible on www.gib.work right now:
/tokenomicsrenders only the nav bar. The page component returned<Nav />and nothing else.alt="Open Source Bounty".aria-expanded, no focus handling, and Escape doesn't close it.twittermetadata, nometadataBase), andpublic/sitemap.xmllists a single URL with lastmod 2024-08-28.What changed:
app/tokenomics/page.tsxis now a minimal real page: $WORK summary, token address, and links to the tokenomics docs, DexScreener and CoinGecko (all sourced from docs.gib.work), plus footer and page metadata.components/looking-for.tsx: Open Source Bounty links to app.gib.work/bounties/create, Simple Task to app.gib.work/tasks/create, Services to the app root (the app has no services route today — checked). Alt texts corrected; a hover border so the cards read as clickable. Note: the/explorelinks used in older PRs 404 now.components/nav.tsx:role="dialog"/aria-modalon the overlay,aria-label/aria-expanded/aria-controlson the hamburger, labelled close button, focus moves to the close button on open and back to the toggle on close, Escape closes, background scroll is locked while the menu is open. Icon-only social links in nav and footer got aria-labels. No visual changes. Addresses Accessibility: keep keyboard focus inside the mobile navigation modal #115 and Improve mobile landing-page navigation accessibility with a focus-trapped dialog #134.app/layout.tsx:metadataBase, twitter card, canonical ("./"resolves per route, verified:/and/tokenomicseach render their own).components/hero.tsx: removed theflowbite-reactimport that was only referenced inside a commented-out block, and gave the dashboard screenshot a real alt.public/sitemap.xml: both routes, current lastmod.npm run buildpasses (types + lint). Mobile menu verified with Playwright:aria-expandedtoggles, focus lands on the close button, Escape closes and returns focus to the toggle.Before/after: