Allow customizing unselected annotation dimming - #2113
Merged
Conversation
Collaborator
Author
|
@manthey not sure what's going on with CI in the Girder 3 base branch, but it looks like the errors I'm seeing here are not being introduced by these changes |
naglepuff
force-pushed
the
mln/configurable-annotation-dimming
branch
from
August 4, 2026 20:00
9f175da to
964927f
Compare
naglepuff
force-pushed
the
mln/configurable-annotation-dimming
branch
from
August 5, 2026 21:14
6d034e7 to
d3d7bce
Compare
manthey
reviewed
Aug 6, 2026
| this._globalAnnotationOpacity = settings.globalAnnotationOpacity || 1.0; | ||
| this._globalAnnotationFillOpacity = settings.globalAnnotationFillOpacity || 1.0; | ||
| this._unselectedOpacityMultiplier = typeof settings.unselectedOpacityMultiplier !== 'number' | ||
| ? 0.25 |
Member
There was a problem hiding this comment.
Since part of the impetus for this was that users found the current value too dim, let's change the default as part of this PR. Let's change it to 0.33 (obviously in both places it appears).
Member
|
Aside from wishing to change the default as part of this, this looks good to me. |
naglepuff
force-pushed
the
mln/configurable-annotation-dimming
branch
from
August 6, 2026 15:28
898dcba to
ef70397
Compare
manthey
approved these changes
Aug 6, 2026
manthey
left a comment
manthey
left a comment
Member
There was a problem hiding this comment.
Some github action on an unrelated code section is failing due to Github infrastructure. If the system will let you merge this despite that problem, go ahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for: DigitalSlideArchive/HistomicsUI#542
Allow passing in
unselectedOpacityMultiplierto thesettingsobject for the GeoJS Image Viewer widget class. If no value is passed (or a non-numerical value is passed), fall back to the0.25as the default (the current hard-coded value).This value is used to determine the opacity for non-selected annotation elements.