fix add event handler not available and observables with different scope#758
Open
mablesly wants to merge 2 commits intogitana:masterfrom
Open
fix add event handler not available and observables with different scope#758mablesly wants to merge 2 commits intogitana:masterfrom
mablesly wants to merge 2 commits intogitana:masterfrom
Conversation
mablesly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add event handler as described in the documentation is not available to the rest of the code as it is added to the field and not to the _events of the field object. As "onAdd" does not exist in the specs, this is ignored and the handler never called. Therefore "add" should be added in the if-clause and to end up in the _event handlers.
The functionality of observables from different scopes didn't work anymore. For some reason the scope of this was added to the arguments and later used as scope. This way the original scope was interpreted as ID of the element.