Repository navigation
Unify concise search and grep output - #460
Merged
Merged
Conversation
Capture the user-selected presentation follow-up after PR 454, with observed output differences, formatter ownership and acceptance criteria. Keep it separate from routing guidance and defer implementation until the concrete output shape is selected.
Specify outcome-first headers, truthful partial and pagination qualifiers, and a shared Read / More results / Follow-up footer. Record verified service constraints, review closures and focused implementation acceptance without changing production behavior or opening a planning-only PR.
Replace the contested pipe-separated counters and unexplained partial labels with proposed outcome sentences and attributed limitation explanations. Mark the headline design under discussion and keep prior review evidence explicitly historical.
Record the user requirement to avoid per-call token overhead from restating Sources and Preparing. Keep one outcome sentence by default and preserve conditional wait guidance only where it changes the next action.
…eader-footer-follow-up
Use plain outcome counts and shared Read, More results and Follow-up footers. Retain exact native actions, source preparation and coverage limitations while keeping JSON and request behavior unchanged.
Keep empty outcomes page-scoped whenever a continuation cursor exists, independently of coverage warnings and terminal omissions. Add regressions for skipped content and unsupported targets, strengthen lifecycle assertions, and record review closure.
Assert page-scoped zero-hit and retained-hit headlines for failed and partial overall traversal, group omission coverage with related tests, and record external review closure.
Keep the verified output contract, evidence and validation limits in implementation documentation. Remove the completed working plan and selected backlog entry after clean internal and Claude review.
jlitola
marked this pull request as ready for review
October 7, 2026 08:02
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search and grep previously mixed outcome counts with lifecycle/readiness flags and used different continuation layouts. Both now use plain outcome sentences and optional Read → More results → Follow-up footers across CLI/MCP, while Sources and Preparing retain concrete provenance and missing scope.
Validation:
bun test5,624 passing; revised nine-file closure 354 passing and final headline assertion closure 19 passing. Typecheck, CLI/MCP builds, source and built smoke checks, and packed public-package validation pass. Smoke live cohorts skip unauthenticated; separate authenticated dev CLI/MCP calls verify pending and healthy search/grep and byte-identical retained status. Durable semantics and evidence are in search snapshot presentation.Fixed output-size comparison: ready search +74 bytes and preparing search +94 bytes for newly actionable footers; paged grep -7 bytes. No token-saving or agent-quality claim. Targeted qualitative Claude workloads were blocked by provider login before tool use.
Internal review and fresh Claude Opus 5.5 round 3, including its final fresh-context check, are clean. Accepted findings fixed misleading empty cursor-page outcomes and missing headline assertions. The completed plan is retired after clean review; current semantics and evidence remain in implementation docs. No major deferral. No merge or release.
CI for final HEAD
9d9c72d: Build & Checks, Linux/Windows tests, MCP package validation and Bun/Node 20/22/24/26 compatibility all pass. Agent-eval and publish jobs are skipped by workflow policy.