Skip to content

Conversation

@henrymercer
Copy link
Contributor

This reduces the likelihood of publishing a tag but not a release.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Dev only

How did/will you validate this change?

  • None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

This reduces the likelihood of publishing a tag but not a release.
@henrymercer henrymercer requested a review from mbg November 13, 2025 17:24
@henrymercer henrymercer requested a review from a team as a code owner November 13, 2025 17:24
Copilot AI review requested due to automatic review settings November 13, 2025 17:24
@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 13, 2025
Copilot finished reviewing on behalf of henrymercer November 13, 2025 17:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders workflow steps to create the mergeback PR after the GitHub release is created, reducing the likelihood of publishing a tag but not a release.

  • The "Create mergeback branch and PR" step is moved from before the release creation to after it
  • The step execution order now ensures the release is fully published before initiating the mergeback process

--notes-file "$PARTIAL_CHANGELOG"
- name: Create mergeback branch and PR
if: ${{ endsWith(github.ref_name, steps.getVersion.outputs.latest_release_branch) }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed this so that we will try to open the mergeback even if the tag exists. This means we can retry generating the mergeback if this workflow fails, even if the tag is already published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants