Detach cli lifespan from the context passed to Client.Start#689
Open
qmuntal wants to merge 1 commit intogithub:mainfrom
Open
Detach cli lifespan from the context passed to Client.Start#689qmuntal wants to merge 1 commit intogithub:mainfrom
qmuntal wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Go SDK issue #668 by ensuring the Copilot CLI subprocess spawned by Client.Start(ctx) is not tied to (and killed by) cancellation of the provided context after startup.
Changes:
- Spawn the CLI process with
exec.Commandinstead ofexec.CommandContextso canceling theStartcontext doesn’t kill the CLI. - Thread the caller context through
ensureConnected(ctx)and simplify foreground session methods to reuse that helper. - Add a regression test asserting that canceling the
Startcontext does not break subsequent CLI requests (Ping).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/client.go | Decouples CLI process lifetime from Start context; refactors connection checks and tightens startup/dial timeouts. |
| go/client_test.go | Adds regression test ensuring Start-context cancellation doesn’t kill the CLI process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #668