Skip to content

[log] Add debug logging to TLS helper functions in proxy/tls.go #9285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Jul 14, 2026
+14 −3
Merged

[log] Add debug logging to TLS helper functions in proxy/tls.go #9285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c31d043
[log] Add debug logging to TLS helper functions in proxy/tls.go
github-actions[bot] Jul 13, 2026
b7cc3ad
fix: address review feedback in proxy/tls.go
Copilot Jul 14, 2026
d123179
fix: log close error in writePEM error path
Copilot Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions internal/proxy/tls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ func GenerateSelfSignedTLS(dir string) (*TLSConfig, error) {
if err := os.MkdirAll(dir, 0755); err != nil {
return nil, fmt.Errorf("failed to create TLS directory %s: %w", dir, err)
}
logTLS.Printf("TLS directory ensured: %s", dir)

// --- Generate CA ---
caKey, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
if err != nil {
return nil, fmt.Errorf("failed to generate CA key: %w", err)
Expand Down Expand Up @@ -190,14 +190,25 @@ func randomSerial() (*big.Int, error) {
if serial.Sign() == 0 {
serial = new(big.Int).Add(serial, big.NewInt(1))
}
logTLS.Printf("generated random serial number: %s", serial)
return serial, nil
}

func writePEM(path, blockType string, derBytes []byte, perm os.FileMode) error {
logTLS.Printf("writing PEM file: path=%s, type=%s, size=%d bytes", path, blockType, len(derBytes))
f, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, perm)
if err != nil {
return err
}
defer f.Close()
return pem.Encode(f, &pem.Block{Type: blockType, Bytes: derBytes})
if err := pem.Encode(f, &pem.Block{Type: blockType, Bytes: derBytes}); err != nil {
if closeErr := f.Close(); closeErr != nil {
logTLS.Printf("failed to close file after encoding error: %v", closeErr)
}
return err
}
if err := f.Close(); err != nil {
return err
}
logTLS.Printf("PEM file written successfully: path=%s", path)
return nil
}
Loading