Skip to content

fix: CLI consistency — rename --no-staged, add -e to logs, grammar/style fixes#45280

Merged
pelikhan merged 2 commits into
mainfrom
copilot/cli-consistency-fixes
Jul 13, 2026
Merged

fix: CLI consistency — rename --no-staged, add -e to logs, grammar/style fixes#45280
pelikhan merged 2 commits into
mainfrom
copilot/cli-consistency-fixes

Conversation

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Automated CLI consistency inspection (run 29255177404) identified 38 issues across grammar, docs/CLI mismatches, and flag naming. This PR addresses the high- and medium-severity flag issues plus all low-severity grammar/style findings.

Flag changes

  • --no-staged--exclude-staged on gh aw logs (High) — eliminates naming conflict with compile --staged, which has completely unrelated semantics
  • -e added to logs --engine (Medium) — addEngineFilterFlag now registers the -e shorthand, consistent with every other --engine flag in the CLI
  • --timeout phrasing standardized to (0 = no timeout) in trial and forecast (was three different phrasings)
  • trial --yes description updated to "Auto-accept trial confirmations (required in CI)" matching deploy/update/upgrade

Grammar & style (all low/medium)

Location Before After
add/add-wizard/deploy/trial --append end of agentic workflow on installation end of **the** agentic workflow…
new command Long (github, claude, MCPs) (GitHub, Claude, MCPs)
env Long in batch for repository… in bulk for **a** repository…
init Long use expires field use **the** expires field
init --codespaces agentic workflows support agentic workflow support
trial Long current repo / in trials/ directory the current repository / in the trials/ directory
logs Long By default only By default**,** only
health Long over time period over **a** time period
pr Long Useful for migrating **This is** useful for migrating
compile --purge no specific files are specified …are **provided**
mcp example in workflow in **a** workflow
coolDownFlagUsage Cooldown period Cool-down period (matches --cool-down flag name)

Docs & test updates

  • docs/setup/cli.md logs options list updated: --no-staged--exclude-staged, --engine--engine/-e
  • ADR 29170 updated to reference --exclude-staged
  • All affected tests updated: TestShortFlagConsistency, TestNewLogsCommand, TestLogsCommandFlags, TestNewForecastCommand_TimeoutFlag, TestApplyRunFilters_NoStaged

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CLI consistency issues identified in inspection fix: CLI consistency — rename --no-staged, add -e to logs, grammar/style fixes Jul 13, 2026
Copilot AI requested a review from pelikhan July 13, 2026 16:02
@github-actions

Copy link
Copy Markdown
Contributor

PR Triage (run 29275650494)\n\nCategory: chore | Risk: low | Score: 42/100 | Action: batch_review | Batch: draft-quality\n\nScore: Impact 18/50 + Urgency 12/30 + Quality 12/20\n\nCLI consistency fixes: rename --no-staged, add -e shorthand, grammar/style fixes. 22 files, +40/-42. DRAFT. Good batch with #45298 and #45282.

Generated by 🔧 PR Triage Agent · 181.5 AIC · ⌖ 7.71 AIC · ⊞ 5.6K ·

@pelikhan pelikhan marked this pull request as ready for review July 13, 2026 21:16
Copilot AI review requested due to automatic review settings July 13, 2026 21:16
@pelikhan pelikhan merged commit 76f2dec into main Jul 13, 2026
@pelikhan pelikhan deleted the copilot/cli-consistency-fixes branch July 13, 2026 21:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes CLI flag naming, shorthands, help text, documentation, and related tests.

Changes:

  • Renames logs --no-staged to --exclude-staged and adds -e for --engine.
  • Standardizes timeout and confirmation help text.
  • Applies grammar and terminology corrections across commands and documentation.
Show a summary per file
File Description
pkg/cli/update_cooldown.go Standardizes cool-down terminology.
pkg/cli/trial_command.go Revises trial help and flag descriptions.
pkg/cli/pr_command.go Improves command grammar.
pkg/cli/mcp.go Corrects example wording.
pkg/cli/logs_orchestrator_filters.go Updates staged-filter messages.
pkg/cli/logs_orchestrator_filters_test.go Updates staged-filter test description.
pkg/cli/logs_filtering_test.go Expects the -e shorthand.
pkg/cli/logs_command.go Renames the staged filter flag.
pkg/cli/logs_command_test.go Tests the engine shorthand.
pkg/cli/init_command.go Corrects initialization help text.
pkg/cli/health_command.go Corrects health help grammar.
pkg/cli/forecast_test.go Updates timeout help assertion.
pkg/cli/forecast_command.go Standardizes timeout wording.
pkg/cli/flags.go Adds -e to engine filters.
pkg/cli/flags_test.go Updates shorthand consistency expectations.
pkg/cli/env_command.go Improves environment command wording.
pkg/cli/deploy_command.go Corrects append flag grammar.
pkg/cli/add_wizard_command.go Corrects append flag grammar.
pkg/cli/add_command.go Corrects append flag grammar.
docs/src/content/docs/setup/cli.md Updates documented logs options.
docs/adr/29170-stdin-input-mode-for-logs-and-audit-commands.md Updates the staged-filter name.
cmd/gh-aw/main.go Corrects capitalization and compile help.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 22/22 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread pkg/cli/logs_command.go
addRepoFlag(logsCmd)
logsCmd.Flags().Bool("tool-graph", false, "Generate Mermaid tool sequence graph from agent logs")
logsCmd.Flags().Bool("no-staged", false, "Exclude workflow runs that executed in staged mode (safe outputs previewed but not applied)")
logsCmd.Flags().Bool("exclude-staged", false, "Exclude workflow runs that executed in staged mode (safe outputs previewed but not applied)")
Comment thread pkg/cli/trial_command.go
cmd.Flags().Bool("delete-host-repo-after", false, "Delete the host repository after completion (kept by default)")
cmd.Flags().Bool("force-delete-host-repo-before", false, "Force delete the host repository before creation if it already exists")
cmd.Flags().BoolP("yes", "y", false, "Skip confirmation prompts")
cmd.Flags().BoolP("yes", "y", false, "Auto-accept trial confirmations (required in CI)")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cli-consistency] CLI Consistency Issues - 2026-07-13

3 participants