fix: CLI consistency — rename --no-staged, add -e to logs, grammar/style fixes#45280
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CLI consistency issues identified in inspection
fix: CLI consistency — rename Jul 13, 2026
--no-staged, add -e to logs, grammar/style fixes
Contributor
PR Triage (run 29275650494)\n\nCategory: chore | Risk: low | Score: 42/100 | Action: batch_review | Batch: draft-quality\n\nScore: Impact 18/50 + Urgency 12/30 + Quality 12/20\n\nCLI consistency fixes: rename --no-staged, add -e shorthand, grammar/style fixes. 22 files, +40/-42. DRAFT. Good batch with #45298 and #45282.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes CLI flag naming, shorthands, help text, documentation, and related tests.
Changes:
- Renames
logs --no-stagedto--exclude-stagedand adds-efor--engine. - Standardizes timeout and confirmation help text.
- Applies grammar and terminology corrections across commands and documentation.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/update_cooldown.go |
Standardizes cool-down terminology. |
pkg/cli/trial_command.go |
Revises trial help and flag descriptions. |
pkg/cli/pr_command.go |
Improves command grammar. |
pkg/cli/mcp.go |
Corrects example wording. |
pkg/cli/logs_orchestrator_filters.go |
Updates staged-filter messages. |
pkg/cli/logs_orchestrator_filters_test.go |
Updates staged-filter test description. |
pkg/cli/logs_filtering_test.go |
Expects the -e shorthand. |
pkg/cli/logs_command.go |
Renames the staged filter flag. |
pkg/cli/logs_command_test.go |
Tests the engine shorthand. |
pkg/cli/init_command.go |
Corrects initialization help text. |
pkg/cli/health_command.go |
Corrects health help grammar. |
pkg/cli/forecast_test.go |
Updates timeout help assertion. |
pkg/cli/forecast_command.go |
Standardizes timeout wording. |
pkg/cli/flags.go |
Adds -e to engine filters. |
pkg/cli/flags_test.go |
Updates shorthand consistency expectations. |
pkg/cli/env_command.go |
Improves environment command wording. |
pkg/cli/deploy_command.go |
Corrects append flag grammar. |
pkg/cli/add_wizard_command.go |
Corrects append flag grammar. |
pkg/cli/add_command.go |
Corrects append flag grammar. |
docs/src/content/docs/setup/cli.md |
Updates documented logs options. |
docs/adr/29170-stdin-input-mode-for-logs-and-audit-commands.md |
Updates the staged-filter name. |
cmd/gh-aw/main.go |
Corrects capitalization and compile help. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 22/22 changed files
- Comments generated: 2
- Review effort level: Medium
| addRepoFlag(logsCmd) | ||
| logsCmd.Flags().Bool("tool-graph", false, "Generate Mermaid tool sequence graph from agent logs") | ||
| logsCmd.Flags().Bool("no-staged", false, "Exclude workflow runs that executed in staged mode (safe outputs previewed but not applied)") | ||
| logsCmd.Flags().Bool("exclude-staged", false, "Exclude workflow runs that executed in staged mode (safe outputs previewed but not applied)") |
| cmd.Flags().Bool("delete-host-repo-after", false, "Delete the host repository after completion (kept by default)") | ||
| cmd.Flags().Bool("force-delete-host-repo-before", false, "Force delete the host repository before creation if it already exists") | ||
| cmd.Flags().BoolP("yes", "y", false, "Skip confirmation prompts") | ||
| cmd.Flags().BoolP("yes", "y", false, "Auto-accept trial confirmations (required in CI)") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated CLI consistency inspection (run 29255177404) identified 38 issues across grammar, docs/CLI mismatches, and flag naming. This PR addresses the high- and medium-severity flag issues plus all low-severity grammar/style findings.
Flag changes
--no-staged→--exclude-stagedongh aw logs(High) — eliminates naming conflict withcompile --staged, which has completely unrelated semantics-eadded tologs --engine(Medium) —addEngineFilterFlagnow registers the-eshorthand, consistent with every other--engineflag in the CLI--timeoutphrasing standardized to(0 = no timeout)intrialandforecast(was three different phrasings)trial --yesdescription updated to"Auto-accept trial confirmations (required in CI)"matchingdeploy/update/upgradeGrammar & style (all low/medium)
add/add-wizard/deploy/trial --appendend of agentic workflow on installationend of **the** agentic workflow…newcommand Long(github, claude, MCPs)(GitHub, Claude, MCPs)envLongin batch for repository…in bulk for **a** repository…initLonguse expires fielduse **the** expires fieldinit --codespacesagentic workflows supportagentic workflow supporttrialLongcurrent repo/in trials/ directorythe current repository/in the trials/ directorylogsLongBy default onlyBy default**,** onlyhealthLongover time periodover **a** time periodprLongUseful for migrating**This is** useful for migratingcompile --purgeno specific files are specified…are **provided**mcpexamplein workflowin **a** workflowcoolDownFlagUsageCooldown periodCool-down period(matches--cool-downflag name)Docs & test updates
docs/setup/cli.mdlogs options list updated:--no-staged→--exclude-staged,--engine→--engine/-e--exclude-stagedTestShortFlagConsistency,TestNewLogsCommand,TestLogsCommandFlags,TestNewForecastCommand_TimeoutFlag,TestApplyRunFilters_NoStaged