Skip to content

Ensure that Nokogiri is at least at 1.18.4 #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxbeizer wants to merge 3 commits into from
+13 −10
Closed

Ensure that Nokogiri is at least at 1.18.4 #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8524bc5
Ensure that Nokogiri is at least at 1.18.4
maxbeizer Mar 31, 2025
7e69dd6
Bundle gems to update lock file
maxbeizer Mar 31, 2025
c31f3fc
Require ruby >= 3.1
maxbeizer Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
strategy:
matrix:
ruby:
- "3.0"
- "3.1"
- "3.2"
- "3.3"
- "3.4"
fail-fast: false

steps:
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ gem "twitter-text", "~> 1.14"
gem "asciidoctor", "~> 2.0.5"
gem "rake"
gem "rexml"
gem "nokogiri", "~> 1.18.4"
16 changes: 9 additions & 7 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,21 @@ GEM
concurrent-ruby (~> 1.0)
logger (1.7.0)
mini_mime (1.1.5)
mini_portile2 (2.8.8)
minitest (5.25.5)
mutex_m (0.3.0)
nokogiri (1.17.2-aarch64-linux)
nokogiri (1.18.7)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.17.2-arm-linux)
nokogiri (1.18.7-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.17.2-arm64-darwin)
nokogiri (1.18.7-arm-linux-gnu)
racc (~> 1.4)
nokogiri (1.17.2-x86-linux)
nokogiri (1.18.7-arm64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-darwin)
nokogiri (1.18.7-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-linux)
nokogiri (1.18.7-x86_64-linux-gnu)
racc (~> 1.4)
nokogiri-diff (0.3.0)
nokogiri (~> 1.5)
Expand Down Expand Up @@ -126,7 +128,7 @@ DEPENDENCIES
html-pipeline (~> 1.0)
kramdown
minitest (~> 5.4, >= 5.4.3)
nokogiri (~> 1.17.2)
nokogiri (~> 1.18.4)
nokogiri-diff (~> 0.3.0)
org-ruby (= 0.9.12)
rake
Expand Down
4 changes: 2 additions & 2 deletions github-markup.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |s|
s.homepage = "https://github.com/github/markup"
s.license = "MIT"

s.required_ruby_version = '>= 3.0.0'
s.required_ruby_version = '>= 3.1.0'

s.files = `git ls-files`.split($\)
s.executables = s.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
Expand All @@ -25,7 +25,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'minitest', '~> 5.4', '>= 5.4.3'
s.add_development_dependency 'html-pipeline', '~> 1.0'
s.add_development_dependency 'sanitize', '>= 4.6.3'
s.add_development_dependency 'nokogiri', '~> 1.17.2'
s.add_development_dependency 'nokogiri', '~> 1.18.4'
s.add_development_dependency 'nokogiri-diff', '~> 0.3.0'
s.add_development_dependency "github-linguist", ">= 7.1.3"
end
Loading