Repository navigation
fix: wait for the restored pointer before calling a modifier click's cleanup unverified - #128
Merged
Merged
Conversation
iamnbutler
added a commit
that referenced
this pull request
Oct 17, 2026
iamnbutler
force-pushed
the
fix/cursor-restoration-readback
branch
from
October 17, 2026 15:09
ee9ed8b to
31ee31c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127.
After a foreground modifier click,
CursorRestorationOwnership.restoremoves the pointer back. It does that by posting a mouse-moved event to the HID event tap, then reads the location straight away. The window server applies posted events after the post returns, so that read still finds the click point. As a result, every Command-click and Shift-click failed its cleanup withDESKTOP_ACTION_FAILEDand "The physical cursor restoration was dispatched but could not be verified". I saw it 4 of 4 times on a Finder fixture with the installed 0.13.1, and in the #77 live checks.New
peekaboo-cursor-readback.patch:Modifier clicks stay
unknownwithDESKTOP_ACTION_UNVERIFIED, because their effect can't be confirmed. Only the false cleanup failure goes away.Verification
ForegroundModifierClick*54 pass, andUIAutomationServiceModifierClickSnapshotTests|SyntheticInputDriver22 pass.npm run build:nativesucceeds,npm testpasses 75, andnpm run checkis clean.--only 77: Command-click and Shift-click should showcursor_restoration: "restored".