Repository navigation
fix: never upscale captures, and name their image metadata image - #69
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from #36.
ace_image→imagedesktop_inspect,desktop_screenanddesktop_menubar_clickresults:{width, height, note}.packages/channel/src/desktop.ts), the only package that depends on desktop-tools, passes through the top-levelimagecontent and never parsesace_image.~/codementions it, and the docs never did.No upscaling
screenshot()usedsips --resampleHeightWidthMax 1600, which enlarges anything smaller than that, such as a narrow display or any window under 1600 px.Checked by running the built
screenshot()on fixtures:npm run checkpasses. No native changes.