Remove requirement to be a logged in user to get a token.#465
Open
Remove requirement to be a logged in user to get a token.#465
Conversation
Since the same token is used for 40 minutes for all users, there's no real security benefit to requiring authentication: one throwaway Google account gets access to all the EarthEngine tokens available in any case. This opens up the possibility of making authentication fully optional: anyone can go to the site front page and have it function normally without having to log in. My plan is to try to silently authorize using available credentials, and then on failure fall back to getting a token from this token server and have a login button on the topbar. If the user wants to log in (say, because they are a privileged user and want access to user-defined shapes), they can, and then the silent authorization should work in the future. Privileged pages like manage_disaster will continue to require the GD user (and never used this token server anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the same token is used for 40 minutes for all users, there's no real security benefit to requiring authentication: one throwaway Google account gets access to all the EarthEngine tokens available in any case.
This opens up the possibility of making authentication fully optional: anyone can go to the site front page and have it function normally without having to log in. My plan is to try to silently authorize using available credentials, and then on failure fall back to getting a token from this token server and have a login button on the topbar. If the user wants to log in (say, because they are a privileged user and want access to user-defined shapes), they can, and then the silent authorization should work in the future.
Privileged pages like manage_disaster will continue to require the GD user (and never used this token server anyway).