XSS mitigation by sanitizing user inputs with bleach #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagolotufo
reviewed
Dec 9, 2024
| dbConn, err := OpenDBConnection() | ||
| if err != nil { | ||
| errOpenDBConnection := fmt.Sprintf("OpenDBConnection error: %s", err) | ||
| errOpenDBConnection := ("OpenDBConnection error: %s" + err) |
Contributor
There was a problem hiding this comment.
I don't see any need to make any changes at this point. Is this change related to the vulnerability found?
Author
There was a problem hiding this comment.
It has nothing to do with the vulnerability, I just understood that it would be a good practice in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution refers to which of the apps?
A3 - Gossip World
What did you do to mitigate the vulnerability?
I mitigated the XSS vulnerability by sanitizing user inputs across the app. I used the bleach library to clean and remove any potentially dangerous HTML tags and scripts from user-generated content, such as comments and posts. This prevents malicious JavaScript from executing in the browser when user content is displayed, thus securing the app from XSS attacks.
Did you test your changes? What commands did you run?
I tested the changes by trying to reproduce the attack narrative in the setup, by injecting JavaScript in comment, post, and search fields. After implementing the sanitization, I confirmed that the injected scripts were no longer executable and displayed as plain text, mitigating the XSS vulnerability.