Send using password: NO when no password is used
#1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnes
changed the title
using password: NO when no password is used
ramnes
force-pushed
the
ramnes/no-password
branch
2 times, most recently
from
e6237fb to
6ed3594
Compare
lance6716
reviewed
Dec 11, 2025
ramnes
force-pushed
the
ramnes/no-password
branch
from
9d40a13 to
e0df29c
Compare
ramnes
force-pushed
the
ramnes/no-password
branch
from
e0df29c to
4d0921f
Compare
lance6716
approved these changes
Dec 11, 2025
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestCheckSha2CacheCredentials_EmptyPassword(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Can this test be put into auth_test.go, below TestCompareSha256PasswordAuthData_EmptyPassword?
Contributor
Author
There was a problem hiding this comment.
do you want to move checkSha2CacheCredentials in auth.go as well?
Collaborator
There was a problem hiding this comment.
Oh, your reason is to use auth_switch_response_test.go to check function in auth_switch_response.go. I think it's reasonable from this view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, the
using password: NOappears when the user password on the server is empty. It should be the opposite: theYESorNOshould depend on the data sent by the client, not the password stored for the user.