Increase 1password automatic login robustness by adding retries + bugfixes#1827
Open
aevangeline wants to merge 1 commit into
Open
Increase 1password automatic login robustness by adding retries + bugfixes#1827aevangeline wants to merge 1 commit into
aevangeline wants to merge 1 commit into
Conversation
…s with a backoff between attempts. This way if FFXIV launcher fails to launch quickly, the automatic login should still work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using the 1password automatic login script for my account that has OTP enabled, and noticed that it would randomly fail. This seems to be caused by a race condition between the software launching and the sleep in the script. To mitigate this, I made it so that the script tries to send the OTP to XIVlauncher with backed-off retries (5 tries, spaced out by 2 seconds each) until it succeeds.
There should be no broader implications to the overall project, and no noticeable change in behavior for existing users of the script.
I also fixed the install directory for XIV launcher so that it uses the most recent path.