GDScript: Add abstract functions to highlight grammar#1000
Merged
Conversation
Also adds `is not`
9291b6c to
c2382a0
Compare
Collaborator
|
@HolonProduction FYI I haven't been particularly strict on the token roles, there's a few contributors that come and correct me every once in a while. The textmate tokenizer IS used for the formatter though (don't ask), so if you do something too outrageous with the highlighting the formatter tests should tell you. (this also means that when there's new grammar in GDScript, it's doubly helpful to make sure it's represented in the tests, because that checks both the formatter and the highlighting [indirectly]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #962
Also adds
is not(although not sure on the role, but it looks fine with the default color scheme)Fixes: #834