release: v0.17.16 - #84
Merged
Merged
Conversation
writeSwizzle now wraps binary/select sub-expressions in parentheses, matching Rust naga is_scoped=false semantics. Without this, C++ member access (.) bound tighter than arithmetic operators, emitting mat * vec.xyz instead of (mat * vec).xyz — a type error rejected by Metal compiler. Discovered via g3d standard.wgsl on Apple M5.
Covers signed branch explicitly — atomicAdd on atomic<i64> must be rejected the same as u64. Width == 8 handles both uniformly, but the test makes the contract visible for future readers.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHADER_INT64_ATOMIC_MIN_MAXcapability boundary(mat * vec).xyzno longer emitted asmat * vec.xyzTest plan
go build ./...go test ./... -count=1— all passgolangci-lint run --timeout=5m— 0 issuesTestRustReference— 100% parityTestSpirvValBinarySummary— 172/172TestMSLInt64AtomicPolicy— 15 rejection + 3 positive casesTestIntegration_SwizzleOfBinaryNeedsParens— regression test