Skip to content

fix(surface): handle nil WritePixels receiver#277

Merged
kolkov merged 1 commit into
gogpu:mainfrom
besmpl:besmpl/fix-surface-writepixels-nil-guard
Jul 25, 2026
Merged

fix(surface): handle nil WritePixels receiver#277
kolkov merged 1 commit into
gogpu:mainfrom
besmpl:besmpl/fix-surface-writepixels-nil-guard

Conversation

@besmpl

@besmpl besmpl commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

This addresses the sole non-blocking follow-up noted during review of #276. It does not change the behavior of configured, released, or unsupported surfaces.

Validation

Passed locally with CGO_ENABLED=0 and GOWORK=off:

  • go test -count=1 . -run '^TestSurfaceWritePixelsNil$'
  • go test -count=1 ./hal/software ./core .
  • go test -count=1 ./...
  • go test -race -count=1 .
  • go test -count=1 -tags rust ./...
  • default and Rust-tagged builds
  • browser WASM root build
  • Android arm64 full build
  • golangci-lint v2.12.2 run --timeout=5m --new-from-rev=upstream/main ./...
  • gofmt and git diff --check

Follow-up to #276.

@besmpl
besmpl requested a review from kolkov as a code owner July 24, 2026 11:56
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kolkov kolkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the follow-up from our #276 review. s == nil guard now matches ReadPixels. Test covers the nil-receiver panic path. LGTM.

@kolkov
kolkov merged commit 5815654 into gogpu:main Jul 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants