Support SwiftSyntax 601 #50
Merged
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
commented
Jun 14, 2025
| "509.0.0..<510.0.0", | ||
| "510.0.0..<511.0.0", | ||
| "511.0.0..<601.0.0", | ||
| "601.0.0..<602.0.0", |
omochi
commented
Jun 14, 2025
| url: "https://github.com/swiftlang/swift-syntax", | ||
| envVar: "SWIFT_SYNTAX_VERSION", | ||
| default: "509.0.0..<601.0.0" | ||
| default: "509.0.0..<602.0.0" |
omochi
commented
Jun 14, 2025
| // From: https://github.com/apple/swift-syntax/blob/d647052/Sources/SwiftSyntaxMacrosTestSupport/Assertions.swift | ||
| extension FixIt.Change { | ||
| // From: https://github.com/swiftlang/swift-syntax/blob/601.0.1/Sources/SwiftSyntaxMacrosGenericTestSupport/Assertions.swift | ||
| fileprivate extension FixIt.Change { |
Contributor
Author
There was a problem hiding this comment.
I copy-pasted the latest code and made some small adjustments.
| replacement: newTrivia.description | ||
| ) | ||
|
|
||
| #if canImport(SwiftSyntax601) |
Contributor
Author
There was a problem hiding this comment.
I added this compile-time conditional.
omochi
commented
Sep 12, 2025
Package.swift
Outdated
| .product(name: "SwiftParser", package: "swift-syntax"), | ||
| .product(name: "SwiftParserDiagnostics", package: "swift-syntax"), | ||
| .product(name: "SwiftSyntax", package: "swift-syntax"), | ||
| .product(name: "SwiftSyntaxBuilder", package: "swift-syntax"), |
Contributor
Author
There was a problem hiding this comment.
In Xcode 26, if this is missing, a warning will appear at build time in the consuming package.
Contributor
Author
There was a problem hiding this comment.
Adding it doesn’t resolve the issue, so I’m reverting it.
|
Let's get this merged in! 😄 |
Contributor
Author
|
Thank you for merging it. |
Owner
|
Thank you! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftSyntax 601 introduced support for SE-0452 (Integer Generic Parameters), which changed the type of
GenericArgumentSyntax.argumentfromTypeSyntaxtoGenericArgumentSyntax.Argument.As a result, the test code could no longer be built with SwiftSyntax 601.
Since
GenericArgumentSyntax.Argumentcan be converted toTypeSyntaxusing.as(TypeSyntax.self), I’ve introduced a compatibility accessor namedargumentCompat600to maintain support for SwiftSyntax 600 and earlier.Note: This change does not implement support for Integer Generic Parameters itself.