docs: switch security reporting to GitHub private vulnerability reporting - #23559
docs: switch security reporting to GitHub private vulnerability reporting#23559Vad1mo wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23559 +/- ##
==========================================
+ Coverage 66.36% 66.59% +0.23%
==========================================
Files 1073 1080 +7
Lines 117716 118628 +912
Branches 2965 2992 +27
==========================================
+ Hits 78120 79001 +881
+ Misses 35292 35267 -25
- Partials 4304 4360 +56
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates Harbor’s security disclosure documentation and GitHub issue intake to route vulnerability reports through GitHub Private Vulnerability Reporting, aligning the repo’s public guidance with the advisory-based workflow.
Changes:
- Updates
SECURITY.mdto direct reporters to GitHub private vulnerability reporting and describe the advisory-driven embargo workflow. - Adds an issue chooser
contact_linksentry to route security reports away from public issues. - Adds a prominent warning to the bug report template to prevent public filing of vulnerabilities.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| SECURITY.md | Switches primary reporting channel to GitHub private vulnerability reporting and updates the disclosure workflow narrative. |
| .github/ISSUE_TEMPLATE/config.yml | Adds an issue chooser contact link for private vulnerability reporting. |
| .github/ISSUE_TEMPLATE/bug_report.md | Adds a top-of-template warning to redirect security reports to the private advisory form. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Mailing lists | ||
| - Use cncf-harbor-security@lists.cncf.io to report security concerns to the Harbor Security Team, who uses the list to privately discuss security issues and fixes prior to disclosure. | ||
| - Join cncf-harbor-distributors-announce@lists.cncf.io for early private information and vulnerability disclosure. Early disclosure may include mitigating steps and additional information on security patch releases. See below for information on how Harbor distributors or vendors can apply to join this list. |
…ting Replace the cncf-harbor-security mailing list with GitHub private vulnerability reporting as the intake channel for security reports, per goharbor/community#292. Private vulnerability reporting is enabled on the repository. - SECURITY.md: point reporters at the Security tab / Report a vulnerability form; describe the advisory-based triage, CVSS, in-band CVE request, and temporary private fork workflow; keep the mailing list only as a fallback for reporters without a GitHub account and for distributor list membership requests - Add issue template contact link routing vulnerability reports to the private advisory form - Add a security warning to the bug report template Signed-off-by: Vadim Bauer <vb@container-registry.com>
Address review feedback: drop the mailing-list fallback so there is a single reporting method, clarify that the reporter can see their own report, and fix template grammar. Signed-off-by: Vadim Bauer <vb@container-registry.com>
1c233be to
a88d675
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
SECURITY.md:14
- The PR says the mailing list remains a fallback for reporters without a GitHub account, but this section only states that an account is required and gives those reporters no reporting path. Please document the promised fallback here so accountless reporters are not blocked from private disclosure.
To report a vulnerability or a security-related issue, use [GitHub private vulnerability reporting](https://github.com/goharbor/harbor/security/advisories/new): open the [Security tab](https://github.com/goharbor/harbor/security) of the affected repository and click **Report a vulnerability**. The report is visible only to you and the Harbor Security Team, which is made up of Harbor maintainers who have committer and release permissions. Reports will be addressed within 3 business days, including a detailed plan to investigate the issue and any potential workarounds to perform in the meantime. Do not report non-security-impacting bugs through this channel. Use [GitHub issues](https://github.com/goharbor/harbor/issues/new/choose) instead. Note that filing a report requires a GitHub account.
Reference implementation of goharbor/community#292 on harbor-next: replace mailing-list-based security reporting with GitHub private vulnerability reporting (PVR) and repository security advisories, so upstream goharbor/harbor can adopt a proven, tested setup. Related: goharbor/community#292, goharbor/harbor#23559 --------- Signed-off-by: aloui ikram <ikram@container-registry.com> Co-authored-by: aloui ikram <ikram@container-registry.com>
- Relax the response SLA: acknowledge within 5 business days, then investigate and follow up, instead of promising a full investigation plan within 3 business days. - Request a CVE from GitHub only where GitHub is eligible as CNA; when another CNA already covers the affected component, coordinate with that CNA instead of filing a duplicate. - Point README.md's vulnerability reporting section at private vulnerability reporting instead of the security mailing list. - List cncf-harbor-security@lists.cncf.io again under Mailing lists, scoped to distributors-list administration, since the Embargo Policy and membership sections still reference it. - Split the reporting paragraph, state the GitHub-account requirement as a deliberate single-channel decision, and stop overloading 'acknowledged' to mean both receipt and triage verdict. - Disable blank issues so reports cannot bypass the issue chooser and its security contact link. - Note that larger artifacts are shared in the temporary private fork; the advisory form is not documented to accept attachments. Signed-off-by: Vadim Bauer <vb@container-registry.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
SECURITY.md:16
- GitHub does not grant access to private vulnerability reports based on committer or release permissions. Proposed reports are visible to repository/organization owners, security managers, and repository admins, while users with write/committer access alone cannot view them. Describing visibility in terms of the Security Team's committer permissions therefore misstates the new channel's confidentiality and access model.
The report is visible only to you and the Harbor Security Team, which is made up of Harbor maintainers who have committer and release permissions. Reports will be acknowledged within 5 business days. The Harbor Security Team will then investigate and follow up with a plan to address the issue and any potential workarounds to perform in the meantime.
Notary is no longer part of Harbor, so listing it as an example dependency in the vulnerability-scope section is misleading. Also normalises PGSql to PostgreSQL in the same list. Signed-off-by: Vadim Bauer <vb@container-registry.com>
Notary is no longer part of Harbor, so advertising Docker Content Trust signing via Notary in the feature list is misleading. Signed-off-by: Vadim Bauer <vb@container-registry.com>
Implements the intake-channel change from goharbor/community#292: replace the
cncf-harbor-security@lists.cncf.iomailing list with GitHub private vulnerability reporting as the channel for reporting security vulnerabilities. Private vulnerability reporting is already enabled on this repository.Changes
cncf-harbor-distributors-announce), the embargo policy, and disclosure timing are unchanged, per the proposal's non-goals.blank_issues_enabled: falseso reports cannot bypass the chooser and its security link.Review feedback addressed
README.mdno longer points at the mailing list; the mailing list is listed again under Mailing lists, correctly scoped; reporter visibility wording and template grammar were fixed earlier.Related