docs: fix .cer/.cert extension mismatch in Docker daemon trust config - #741
Open
Adityakumar37 wants to merge 1 commit into
Open
docs: fix .cer/.cert extension mismatch in Docker daemon trust config#741Adityakumar37 wants to merge 1 commit into
Adityakumar37 wants to merge 1 commit into
Conversation
Signed-off-by: Aditya <amanssm221@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes goharbor/harbor#23534 — corrects a mismatch between the documented
certificate extension (
.cert) and the extension actually produced bythe example OpenSSL command (
.cer) in the "Configure the Docker Daemonto Trust the Certificate" section of the HTTPS configuration guide.
Why
The docs state that the Docker daemon requires the
.certextension,but the example command generates a
.cerfile:A reader who copies the command as written ends up with a
.cerfile,which Docker's
certs.dcertificate loader does not recognize, whilethe very next step in the same doc copies
yourdomain.com.certinto/etc/docker/certs.d/. This mismatch causes copy-paste failures thatsurface later as an unrelated-looking
x509: certificate signed by unknown authorityerror.Note for reviewers: older release branches (e.g. release-2.1.0,
release-2.3.0) have this command correct as
.certthis appears tobe a regression introduced at some point on
main.Change
One-line fix: corrected the
-outfilename in the example command from.certo.cert, matching the surrounding prose and the subsequentcpcommands.Additional context (re: issue's follow-up question)
The issue also asks whether
.certis a hard Docker requirement oncertificate content, or a naming convention. It's the latter
Docker's
certs.dloader (/etc/docker/certs.d/<registry>/)distinguishes files purely by filename suffix (
ca.crtfor CA certs,*.certfor the client cert,*.keyfor the key); the underlying PEMformat is identical regardless of extension. Not adding this to the
doc body in this PR to keep the diff minimal per the incremental-PR
guidance in CONTRIBUTING.md — happy to add a clarifying note as a
follow-up if maintainers want it inline.
Closes goharbor/harbor#23534