Open
Conversation
af4886a to
9634d88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Implement Tokenizer Auto-Download from GCS
Description
Implements automatic downloading and caching of tokenizer files from GCS (
gs://) to the local machine. This improves the developer experience by removing the requirement to manually download vocab files from GCS buckets.Changes
gemma/gm/utils/_file_cache.py:maybe_get_from_cacheto detectgs://paths.gs://path is provided and the file is not found in the local cache (~/.gemma/by default), it automatically downloads the file usingetils.epath.gemma/gm/text/_tokenizer.py:Verification
verify_tokenizer_download.pythat mocksetils.epathand GCS access.gs://paths trigger a download to the cache directory.How to test
Set
GEMMA_CACHE_DIRto a temporary directory if you want to avoid contaminating your~/.gemmadirectory, then initialize aGemma2TokenizerorGemma3Tokenizer. The model should download the.modelfile on the first run.