Skip to content

Fix _projections_test.py: Remove prints and use optax.tree.allclose. #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix _projections_test.py: Remove prints and use optax.tree.allclose. #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions optax/projections/_projections_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,43 +244,31 @@ def test_projection_vector(self):
a = (3.0, 4.0)
y_actual = proj.projection_vector(x, a)
y_expected = (33 / 25, 44 / 25)
assert tree_allclose(y_actual, y_expected)
assert optax.tree.allclose(y_actual, y_expected)

def test_projection_hyperplane(self):
x = (1.0, 2.0)
a = (3.0, 4.0)
b = 5.0
y_actual = proj.projection_hyperplane(x, a, b)
y_expected = (7 / 25, 26 / 25)
print(y_actual)
print(y_expected)
assert tree_allclose(y_actual, y_expected)
assert optax.tree.allclose(y_actual, y_expected)

def test_projection_halfspace_1(self):
x = (1.0, 2.0)
a = (3.0, 4.0)
b = 5.0
y_actual = proj.projection_halfspace(x, a, b)
y_expected = (7 / 25, 26 / 25)
print(y_actual)
print(y_expected)
assert tree_allclose(y_actual, y_expected)
assert optax.tree.allclose(y_actual, y_expected)

def test_projection_halfspace_2(self):
x = (1.0, -2.0)
a = (3.0, 4.0)
b = 5.0
y_actual = proj.projection_halfspace(x, a, b)
y_expected = x
print(y_actual)
print(y_expected)
assert tree_allclose(y_actual, y_expected)


def tree_allclose(a, b, rtol=1e-05, atol=1e-08, equal_nan=False):
# Replace this with optax.tree.allclose, once that's added.
return all(jax.tree.leaves(jax.tree.map(lambda a, b: jnp.allclose(
a, b, rtol=rtol, atol=atol, equal_nan=equal_nan), a, b)))
assert optax.tree.allclose(y_actual, y_expected)


if __name__ == '__main__':
Expand Down
Loading