Encode redirect URL value #18
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not completely sure why does
encodeRedirectURLnot handle this. Documentation for this method states that it tries to determine whether encoding is needed or not. And for some reason it does not encode providedredirectURL.When
redirectURLis not encoded, only the first argument (code) is then taken from the URL in the/linkendpoint.When
redirectURLis encoded, bothcodeandstateis parsed from the URL correctly and Google endpoint does not complain about missingstateargument anymore.