Skip to content

Improve doc comment for GIDSignInButtonStyle #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamimi01 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve doc comment for GIDSignInButtonStyle #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f3ed94
fix: Document comment for GIDSignInButtonStyle
kamimi01 Aug 21, 2022
30180b0
Merge branch 'main' into feature/fix-document-comments
w-goog Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignInButton.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ NS_ASSUME_NONNULL_BEGIN
///
/// The minimum size of the button depends on the language used for text.
/// The following dimensions (in points) fit for all languages:
/// - kGIDSignInButtonStyleStandard: 230 x 48
/// - kGIDSignInButtonStyleWide: 312 x 48
/// - kGIDSignInButtonStyleIconOnly: 48 x 48 (no text, fixed size)
/// - kGIDSignInButtonStyleStandard: 230 x 48 (Display text is "Sign in")
Copy link
Contributor

@w-goog w-goog Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future-proofing this a bit :)

Suggested change
/// - kGIDSignInButtonStyleStandard: 230 x 48 (Display text is "Sign in")
/// - kGIDSignInButtonStyleStandard: 230 x 48 (Example display text: "Sign in")

/// - kGIDSignInButtonStyleWide: 312 x 48 (Display text is "Sign in with Google")
Copy link
Contributor

@w-goog w-goog Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - kGIDSignInButtonStyleWide: 312 x 48 (Display text is "Sign in with Google")
/// - kGIDSignInButtonStyleWide: 312 x 48 (Example display text: "Sign in with Google")

/// - kGIDSignInButtonStyleIconOnly: 48 x 48 (no text, fixed size)
typedef NS_ENUM(NSInteger, GIDSignInButtonStyle) {
kGIDSignInButtonStyleStandard = 0,
kGIDSignInButtonStyleWide = 1,
Expand Down
Loading