Fix memory outdated planning optimization invalidated by reshapes.#10157
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 6, 2026
Merged
Fix memory outdated planning optimization invalidated by reshapes.#10157copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
Bot
force-pushed
the
test_910218321
branch
3 times, most recently
from
c3ae1a1 to
cc9f3b7
Compare
When XNNPack's memory planner finds a node that can be computed in place because the input and output shapes are the same, it aliases the output data pointer to the input buffer. After a reshape, this optimization may not be valid anymore. For instance, an input could require a broadcast and be smaller than its output: this happens in our own test cases and was hidden by the face that the inputs and outputs were external values (which disables the above optimization). PiperOrigin-RevId: 911271536
copybara-service
Bot
force-pushed
the
test_910218321
branch
from
cc9f3b7 to
b12ed13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory outdated planning optimization invalidated by reshapes.
When XNNPack's memory planner finds a node that can be computed in place
because the input and output shapes are the same, it aliases the output data
pointer to the input buffer.
After a reshape, this optimization may not be valid anymore. For instance, an
input could require a broadcast and be smaller than its output: this happens in
our own test cases and was hidden by the face that the inputs and outputs were
external values (which disables the above optimization).