Refactor LUT fusion#9973
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
This refactors the implementation of `rewrite_subgraph_for_unary_lut` to work more like `fold_constants`: it duplicates the entire graph, then removes the parts that are fused/folded from the main subgraph, and removes everything else from the duplicate. Then it executes the duplicate to implement constant folding or LUT generation. This eliminates the need for `clone_subgraph_subset`. I've lately found myself fixing the tests for that often, and this approach doesn't need that extra utility or helper function. This should also be faster (but the cost of this should generally be negligible anyways). PiperOrigin-RevId: 899785919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor LUT fusion
This refactors the implementation of
rewrite_subgraph_for_unary_lutto work more likefold_constants: it duplicates the entire graph, then removes the parts that are fused/folded from the main subgraph, and removes everything else from the duplicate. Then it executes the duplicate to implement constant folding or LUT generation.This eliminates the need for
clone_subgraph_subset. I've lately found myself fixing the tests for that often, and this approach doesn't need that extra utility or helper function.This should also be faster (but the cost of this should generally be negligible anyways).