Add overflow checks to reduce-nd workspace sizing#9988
Open
TristanInSec wants to merge 1 commit intogoogle:masterfrom
Open
Add overflow checks to reduce-nd workspace sizing#9988TristanInSec wants to merge 1 commit intogoogle:masterfrom
TristanInSec wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The workspace size for reduce operations is computed by multiplying normalized input shape dimensions as size_t values. On 32-bit platforms, this can overflow to zero or a small value, causing an undersized workspace allocation that the reduction kernel then writes past. Add __builtin_mul_overflow checks to both the innermost and non-innermost reduction paths, returning xnn_status_invalid_parameter when the workspace size would overflow.
TristanInSec
force-pushed
the
fix-reduce-workspace-overflow
branch
from
d06e1bd to
8950c56
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__builtin_mul_overflowchecks to workspace size computation inreshape_reduce_nd()xnn_status_invalid_parameterwhen the workspace size would overflowTest plan