[SPE] Skip SAMPLE events to avoid unsupported PERF_SAMPLE_REGS_USER#259
Open
kugan-nv wants to merge 1 commit intogoogle:masterfrom
Open
[SPE] Skip SAMPLE events to avoid unsupported PERF_SAMPLE_REGS_USER#259kugan-nv wants to merge 1 commit intogoogle:masterfrom
kugan-nv wants to merge 1 commit intogoogle:masterfrom
Conversation
This patch avoids reading PERF samples that is not relavent. We only need AUXTRACE events for SPE data. This filtering is similar to what is already done in other places.
dhoekwater
requested changes
Jan 5, 2026
Collaborator
dhoekwater
left a comment
dhoekwater
left a comment
There was a problem hiding this comment.
One minor comment, but LGTM.
| // Read the perf data file | ||
| quipper::PerfReader reader; | ||
| // Skip SAMPLE events to avoid unsupported PERF_SAMPLE_REGS_USER | ||
| // We only need AUXTRACE events for SPE data |
Collaborator
There was a problem hiding this comment.
SAMPLE events aren't needed for single-process SPE profiles, but we do use them to attribute SPE samples to the right PID when collecting system-wide profiles (see https://github.com/google/autofdo/blob/master/spe_tid_pid_provider.h).
It looks like the SimpleSpeDataSampleReader only operates on single-process SPE profiles, so you still don't need SAMPLE events, but it might be worth calling out that you'd need these events if you want to add support for system-wide SPE profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch avoids reading PERF samples that is not relavent. We only need AUXTRACE events for SPE data. This filtering is similar to what is already done in other places.