Fix incorrect assertion from #251

[dc03-work]

I forgot to remove this assert as it was not compiled in Release mode.

[snehasish]

Looks like one of the llvm_propeller tests failed and blocked the gcov tests from running on the CI. Can you disable it in the same PR? Maybe @dhoekwater can take a look at why it's failing later.

The following tests FAILED:
	 13 - llvm_propeller_perf_branch_frequencies_aggregator_test (Failed)

[dhoekwater]

Looks like one of the llvm_propeller tests failed and blocked the gcov tests from running on the CI. Can you disable it in the same PR? Maybe @dhoekwater can take a look at why it's failing later.

The following tests FAILED:
	 13 - llvm_propeller_perf_branch_frequencies_aggregator_test (Failed)

Looks like commit 975aadd broke llvm_propeller_perf_branch_frequencies_aggregator_test. We can repro it on a fresh install:

git clone https://github.com/google/autofdo.git
cd autofdo

git checkout 975aadd929cbe4995773e3676df1319f95d10916

# Initialize and update all submodules
git submodule update --init --recursive

cmake -DENABLE_TOOL=LLVM \
       -DCMAKE_BUILD_TYPE=Release \
       -DCMAKE_CXX_COMPILER=clang++ \
       -DCMAKE_C_COMPILER=clang \
       -B build-llvm

make -j $(nproc) -C build-llvm
make test -C build-llvm

...
│       Start 13: llvm_propeller_perf_branch_frequencies_aggregator_test                                                                             │
│ 13/39 Test #13: llvm_propeller_perf_branch_frequencies_aggregator_test ...***Failed    0.73 sec                                                    │
...

Looks safe to disregard the failure for this PR!

[snehasish]

hi @dc03-work can you rebase on #262 ? That should fix the failing test and we should also run the gcov ones.

[dc03-work]

hi @dc03-work can you rebase on #262 ? That should fix the failing test and we should also run the gcov ones.

Done!