Update JavaScript dependencies and bump ESLint to v10#1131
Closed
Update JavaScript dependencies and bump ESLint to v10#1131
Conversation
This commit updates dependencies in the `javascript/` and `demo/` directories to their latest versions. Most notably, it bumps ESLint to v10.0.0 and `@eslint/js` to v10.0.1, resolving issues that prevented Dependabot from automatically updating them. To support ESLint v10, `prettier` and `@typescript-eslint/parser` were explicitly added to `devDependencies` in `javascript/package.json`. Additionally, `npm install` for the JavaScript package now requires the `--legacy-peer-deps` flag due to peer dependency constraints in `typescript-eslint` v8. Linting issues introduced by the new dependency versions were fixed in `javascript/src/cli.ts`. Tested with `npm run lint` and `npm test` in `javascript/`, and verified the build in `demo/`. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit updates dependencies in the `javascript/` and `demo/` directories to their latest versions. Most notably, it bumps ESLint to v10.0.0 and `@eslint/js` to v10.0.1, resolving issues that prevented Dependabot from automatically updating them. Key changes: - Upgraded ESLint to v10.0.0 and updated other related dependencies. - Added `@typescript-eslint/parser` and `prettier` to `devDependencies` in `javascript/package.json` to support ESLint v10 and fix linting regerssions. - Fixed linting issues in `javascript/src/cli.ts` introduced by new dependency versions. - Updated GitHub Actions workflows (`javascript-unittest.yml`, `style-check.yml`, and `build-demo.yml`) to include the `--legacy-peer-deps` flag during `npm install` for the `javascript` package. This is necessary because some plugins have not yet updated their peer dependency ranges to include ESLint v10. Tested with `npm run lint` and `npm test` in `javascript/`, and verified the build in `demo/`. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
This commit updates dependencies in the `javascript/` and `demo/` directories to their latest stable and compatible versions. Specifically, it addresses the issue where Dependabot was failing to update ESLint because it was trying to bump to version 10, which currently has peer dependency conflicts with `typescript-eslint` version 8. Changes: - Updated `eslint` and `@eslint/js` to `9.39.2` (the latest stable 9.x release). - Explicitly added `@typescript-eslint/parser` and `prettier` to `devDependencies` in `javascript/package.json` to ensure a clean dependency tree. - Configured `.github/dependabot.yml` to ignore ESLint 10+ for now, preventing future failing PRs until the ecosystem supports the upgrade without workarounds. - Updated all other JavaScript and demo dependencies (like `typescript`, `esbuild`, `vitest`) to their latest stable versions. - Fixed a minor linting regression in `javascript/src/cli.ts`. By staying on ESLint 9 for now, we maintain a stable development environment that works with standard `npm install` without requiring the `--legacy-peer-deps` flag. Tested with `npm run lint` and `npm test` in `javascript/`, and verified the build in `demo/`. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
tushuhei
deleted the
update-dependencies-eslint-10-16208900603446248414
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all JavaScript dependencies, including a major bump to ESLint 10. Added required peer dependencies to resolve installation and execution issues. Fixed minor linting regressions.
PR created automatically by Jules for task 16208900603446248414 started by @tushuhei