feat: add LoadTaskProcess api in containerd client #3723
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sambhav-jain-16
force-pushed
the
task-status
branch
from
a53fbe6 to
88a7bcc
Compare
This commit aims to add an api to get the task process of the containerd client. We have a use case where we are trying to consume the exited containers and get their exit code however the current implementation of the cliet dosn't expose this api. The broader issue and usecase is captured here google#3722.
sambhav-jain-16
force-pushed
the
task-status
branch
from
88a7bcc to
79fafba
Compare
|
@cwangVT Do you have any more concerns with the PR ? If not could you approve this for Testing / Merging ? |
The test triggered and passed. The change looks good. @bobbypage can you pls check as a second pair of eyes. |
|
@bobbypage could you please take a look at this PR and let us know if you have any concerns? |
|
@cwangVT can we merge this ? |
|
@sambhav-jain-16 are you saying that you need this for your own purpose rather than something needed for cadvisor itself? |
4 participants
This commit aims to add an api to get the task process of the containerd client.
We have a use case where we are trying to consume the exited containers and get their exit code however the current implementation of the client doesn't expose this api.
The broader issue and use case is captured here
#3722, currently we are working on a workaround and require this api.