Skip to content

Conversation

@K0zero
Copy link

@K0zero K0zero commented Mar 16, 2023

from go build github.com/google/trillian/server/trillian_log_server/ to go build github.com/google/trillian/cmd/trillian_log_server/

Checklist

from go build github.com/google/trillian/server/trillian_log_server/ to
go build github.com/google/trillian/cmd/trillian_log_server/
@K0zero K0zero requested a review from a team as a code owner March 16, 2023 07:56
@K0zero K0zero requested review from getagit and removed request for a team March 16, 2023 07:56
@google-cla
Copy link

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

echo 'Building Trillian log code'
go build github.com/google/trillian/server/trillian_log_server/
go build github.com/google/trillian/server/trillian_log_signer/
go build github.com/google/trillian/cmd/trillian_log_server/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is closer to being right, but the command still won't work because Go tooling has changed a lot over the years. What this now needs is something more like go install github.com/google/trillian/cmd/trillian_log_server@latest (note the @version).

Did you get this to work? Or has it provided value for understanding how to run it? I ask because it feels like the best thing to do is to delete this script as it is so far out of date, and to my knowledge nobody has run it for a long time. On the other hand, if you are sending a PR to update it, then maybe it is useful?! :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this script is out of date too, but it did work on my machine with the local filesystem path (such like /home/go/src/github.com/google/trillian/server/trillian_log_server/ )
maybe i was the latest one who wanna deploy this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants