Skip to content

fix(rust: builder): add lifetime bounds to finish methods #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −4
Open

fix(rust: builder): add lifetime bounds to finish methods #8750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a9222
fix(rust: builder): add lifetime bounds to finish methods
dallasmarlow Oct 31, 2025
a3134b3
Merge remote-tracking branch 'upstream/master'
dallasmarlow Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions rust/flatbuffers/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,10 @@ impl<'fbb, A: Allocator> FlatBufferBuilder<'fbb, A> {
/// internal state of the FlatBufferBuilder as `finished`. Afterwards,
/// users can call `finished_data` to get the resulting data.
#[inline]
pub fn finish_size_prefixed<T>(&mut self, root: WIPOffset<T>, file_identifier: Option<&str>) {
pub fn finish_size_prefixed<T>(&mut self, root: WIPOffset<T>, file_identifier: Option<&str>)
where
T: 'fbb,
{
self.finish_with_opts(root, file_identifier, true);
}

Expand All @@ -526,15 +529,21 @@ impl<'fbb, A: Allocator> FlatBufferBuilder<'fbb, A> {
/// FlatBufferBuilder as `finished`. Afterwards, users can call
/// `finished_data` to get the resulting data.
#[inline]
pub fn finish<T>(&mut self, root: WIPOffset<T>, file_identifier: Option<&str>) {
pub fn finish<T>(&mut self, root: WIPOffset<T>, file_identifier: Option<&str>)
where
T: 'fbb,
{
self.finish_with_opts(root, file_identifier, false);
}

/// Finalize the FlatBuffer by: aligning it and marking the internal state
/// of the FlatBufferBuilder as `finished`. Afterwards, users can call
/// `finished_data` to get the resulting data.
#[inline]
pub fn finish_minimal<T>(&mut self, root: WIPOffset<T>) {
pub fn finish_minimal<T>(&mut self, root: WIPOffset<T>)
where
T: 'fbb,
{
self.finish_with_opts(root, None, false);
}

Expand Down Expand Up @@ -689,7 +698,9 @@ impl<'fbb, A: Allocator> FlatBufferBuilder<'fbb, A> {
root: WIPOffset<T>,
file_identifier: Option<&str>,
size_prefixed: bool,
) {
) where
T: 'fbb,
{
self.assert_not_finished("buffer cannot be finished when it is already finished");
self.assert_not_nested(
"buffer cannot be finished when a table or vector is under construction",
Expand Down