Refactor custom printer extension points.#1978
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Refactor custom printer extension points.#1978copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
cl/864980702
branch
from
6003ab2 to
9ad6a34
Compare
The source code printing extension point `FuzzTestPrintSourceCode` is changed to be consistent with `AbslStringify`. The custom printer auto-detection is simplified: a type is considered to have a custom printer if it has either `AbslStringify` or `FuzzTestPrintSourceCode` (or both). `AbslStringify` is used for human-readable mode, and `FuzzTestPrintSourceCode` is used for the source-code mode. Either is a fallback if the other extension point is missing. PiperOrigin-RevId: 864980702
copybara-service
bot
force-pushed
the
cl/864980702
branch
from
9ad6a34 to
da120ee
Compare
copybara-service
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor custom printer extension points.
The source code printing extension point
FuzzTestPrintSourceCodeis changed tobe consistent with
AbslStringify. The custom printer auto-detection issimplified: a type is considered to have a custom printer if it has either
AbslStringifyorFuzzTestPrintSourceCode(or both).AbslStringifyis usedfor human-readable mode, and
FuzzTestPrintSourceCodeis used for thesource-code mode. Either is a fallback if the other extension point is missing.