Repository navigation
Conversation
Adds the five campaigns endpoints for organizations:
ListCampaigns (GET /orgs/{org}/campaigns)
CreateCampaign (POST /orgs/{org}/campaigns)
GetCampaign (GET /orgs/{org}/campaigns/{campaign_number})
UpdateCampaign (PATCH /orgs/{org}/campaigns/{campaign_number})
DeleteCampaign (DELETE /orgs/{org}/campaigns/{campaign_number})
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4680 +/- ##
=======================================
Coverage 98.63% 98.64%
=======================================
Files 201 202 +1
Lines 18951 19010 +59
=======================================
+ Hits 18693 18752 +59
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 28, 2026
Comment on lines
+117
to
+123
| var v *CreateCampaignRequest | ||
| assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) | ||
|
|
||
| testMethod(t, r, "POST") | ||
| if !cmp.Equal(*v, input) { | ||
| t.Errorf("Request body = %+v, want %+v", *v, input) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| var v *CreateCampaignRequest | |
| assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) | |
| testMethod(t, r, "POST") | |
| if !cmp.Equal(*v, input) { | |
| t.Errorf("Request body = %+v, want %+v", *v, input) | |
| } | |
| testMethod(t, r, "POST") | |
| testJSONBody(t, r, input) |
Comment on lines
+235
to
+241
| var v *UpdateCampaignRequest | ||
| assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) | ||
|
|
||
| testMethod(t, r, "PATCH") | ||
| if !cmp.Equal(*v, input) { | ||
| t.Errorf("Request body = %+v, want %+v", *v, input) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| var v *UpdateCampaignRequest | |
| assertNilError(t, json.NewDecoder(r.Body).Decode(&v)) | |
| testMethod(t, r, "PATCH") | |
| if !cmp.Equal(*v, input) { | |
| t.Errorf("Request body = %+v, want %+v", *v, input) | |
| } | |
| testMethod(t, r, "PATCH") | |
| testJSONBody(t, r, input) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the five organization campaigns endpoints, which were the only ones
script/metadata.sh unusedstill listed for the campaigns API:ListCampaigns—GET /orgs/{org}/campaignsCreateCampaign—POST /orgs/{org}/campaignsGetCampaign—GET /orgs/{org}/campaigns/{campaign_number}UpdateCampaign—PATCH /orgs/{org}/campaigns/{campaign_number}DeleteCampaign—DELETE /orgs/{org}/campaigns/{campaign_number}The methods live on
OrganizationsServiceinorgs_campaigns.go, followingorgs_codesecurity_configurations.go, since every path is under/orgs/{org}/.Request body field optionality follows the OpenAPI description and passes
script/check-schema-fields.shwith no new findings. Generated accessors anditerators come from
script/generate.sh.the diff myself and ran
script/lint.shand the test suite locally.