Skip to content

fixes parsing bug in sflow packets with ip records #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aelg wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

fixes parsing bug in sflow packets with ip records #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions layers/sflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,8 @@ type SFlowIpv4Record struct {
func decodeSFlowIpv4Record(data *[]byte) (SFlowIpv4Record, error) {
si := SFlowIpv4Record{}

// ignore EnterpriseID and Format (4 byte), and flow data length (4 byte)
*data = (*data)[8:]
*data, si.Length = (*data)[4:], binary.BigEndian.Uint32((*data)[:4])
*data, si.Protocol = (*data)[4:], binary.BigEndian.Uint32((*data)[:4])
*data, si.IPSrc = (*data)[4:], net.IP((*data)[:4])
Expand Down Expand Up @@ -1792,6 +1794,8 @@ type SFlowIpv6Record struct {
func decodeSFlowIpv6Record(data *[]byte) (SFlowIpv6Record, error) {
si := SFlowIpv6Record{}

// ignore EnterpriseID and Format (4 byte), and flow data length (4 byte)
*data = (*data)[8:]
*data, si.Length = (*data)[4:], binary.BigEndian.Uint32((*data)[:4])
*data, si.Protocol = (*data)[4:], binary.BigEndian.Uint32((*data)[:4])
*data, si.IPSrc = (*data)[16:], net.IP((*data)[:16])
Expand Down