fix: declare SOAR dotenv dependency - #259
Merged
dandye merged 1 commit intoAug 29, 2026
Merged
Conversation
Contributor
Author
|
This is ready for review. The SOAR dotenv dependency is now declared, and the visible checks are green. |
Haihan-Jiang
force-pushed
the
add-secops-soar-dotenv-dependency
branch
from
August 29, 2026 02:36
9b08a36 to
b442f2f
Compare
dandye
self-requested a review
August 29, 2026 22:40
dandye
approved these changes
Aug 29, 2026
dandye
left a comment
dandye
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix, @Haihan-Jiang !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SecOps SOAR package imports
dotenvfromsecops_soar_mcp.bindings, butpython-dotenvis not listed in the package dependencies.This adds the missing runtime dependency to
server/secops-soar/pyproject.toml.Tests:
python3 -m py_compile server/secops-soar/secops_soar_mcp/bindings.pypython3 -m pip install --dry-run ./server/secops-soar(metadata prepared; dependency resolution then stopped because the local Python is 3.9 and the existingmcp>=1.4.1requirement needs Python 3.10+)git diff --check