Skip to content

fix(secops): resolve entity_lookup formatter issues (#269) #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dandye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(secops): resolve entity_lookup formatter issues (#269) #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions server/secops/secops_mcp/tools/entity_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,14 @@ async def lookup_entity(
if hasattr(entity, 'metadata') and hasattr(entity.metadata, 'entity_type'):
entity_type = entity.metadata.entity_type

result += f'{i}. Type: {entity_type}\n'
name = getattr(entity, 'name', 'Unknown')
extra = ''
if hasattr(entity, 'entity') and isinstance(entity.entity, dict):
if 'asset' in entity.entity and 'ip' in entity.entity['asset']:
extra = f" ip={','.join(entity.entity['asset']['ip'])}"
elif 'domain' in entity.entity and 'name' in entity.entity['domain']:
extra = f" domain={entity.entity['domain']['name']}"
result += f'{i}. {name} (Type: {entity_type}){extra}\n'

if len(related_entities) > 5:
result += f'... and {len(related_entities) - 5} more related entities\n'
Expand Down Expand Up @@ -185,7 +192,10 @@ async def lookup_entity(

# Add prevalence information if available
if hasattr(entity_summary, 'prevalence') and entity_summary.prevalence:
result += 'Prevalence Information Available\n\n'
result += 'Prevalence:\n'
for p in entity_summary.prevalence[:10]:
result += f' - {p.prevalence_time}: count={p.count}\n'
result += '\n'

return result
except Exception as e:
Expand Down