PoC: Audience segmentation error as notice. - #13296
Draft
JakePT wants to merge 1 commit into
Draft
Conversation
🎭 Playwright reports for c0a6053: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A proof-of-concept for using a notice component for the audience segmentation errors, for consistency with the setup error notices.
Inline TODOs indicate remaining work. Functionality for these will need to mirror
ReportErrorActions, which the previous implementation used but will not work inside aNotice.Also worth considering:
ErrorWidgetContentor be a new component conditionally rendered in its place behind a feature flag.ErrorWidgetContentcan just be put intoAudienceSegmentationErrorWidgetand the intersection observer wrapped around theNoticesoErrorWidgetContentandErrorWidgetDetailscan be deleted.ReportErrorActionsso that it can be shared between it and this component.Related issue(s):
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist