Skip to content

PoC: Audience segmentation error as notice. - #13296

Draft
JakePT wants to merge 1 commit into
developfrom
poc/13295-audience-segmentation-error
Draft

PoC: Audience segmentation error as notice.#13296
JakePT wants to merge 1 commit into
developfrom
poc/13295-audience-segmentation-error

Conversation

@JakePT

@JakePT JakePT commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

A proof-of-concept for using a notice component for the audience segmentation errors, for consistency with the setup error notices.

Inline TODOs indicate remaining work. Functionality for these will need to mirror ReportErrorActions, which the previous implementation used but will not work inside a Notice.

Also worth considering:

  1. Whether this should replace ErrorWidgetContent or be a new component conditionally rendered in its place behind a feature flag.
  2. Whether the contents of the updated ErrorWidgetContent can just be put into AudienceSegmentationErrorWidget and the intersection observer wrapped around the Notice so ErrorWidgetContent and ErrorWidgetDetails can be deleted.
  3. Whether to abstract some of the functionality from ReportErrorActions so that it can be shared between it and this component.

Related issue(s):

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

🎭 Playwright reports for c0a6053:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update style of audience segmentation widget errors

1 participant