Skip to content

Fix line chart tooltip stacking above the header and navigation on scroll - #13300

Open
sileshidev-lab wants to merge 2 commits into
google:developfrom
sileshidev-lab:fix/linechart-tooltip-zindex
Open

Fix line chart tooltip stacking above the header and navigation on scroll#13300
sileshidev-lab wants to merge 2 commits into
google:developfrom
sileshidev-lab:fix/linechart-tooltip-zindex

Conversation

@sileshidev-lab

Copy link
Copy Markdown

Summary

Fixes #13235 — clicking a point on the line chart in "Find out how your audience is growing" pins its tooltip open; scrolling then moves the tooltip up over the sticky header and navigation chips instead of behind them.

#4360 and #4496 fixed this same class of bug for the other dashboard charts (PieChart tooltip), via PR #4549, which added z-index: 8; to the PieChart tooltip selector in three SCSS files. The .googlesitekit-chart--LineChart div.google-visualization-tooltip selector — sitting right next to the PieChart one in the same file — never got that treatment, so the line chart's tooltip (used by the "audience growing" widget's UserCountGraph) was left with no z-index at all.

Fix: add the same z-index: 8; to the LineChart tooltip selector in _googlesitekit-chart.scss, matching the existing PieChart rule immediately below it. Confirmed the header's z-index (11, in _googlesitekit-header.scss) is higher, so this correctly puts the tooltip behind it.

Verification

  • Confirmed via the Storybook Loaded story for DashboardAllTrafficWidgetGA4 (which renders the UserCountGraph line chart with real data) that pinning a tooltip and inspecting the live rendered element shows z-index: 8 actually applied — not just present in source, but compiled and loaded in the browser
  • npx stylelint on the changed file — clean
  • No new Storybook stories/VRT needed — this fixes stacking behavior on an already-covered chart selector, same as the precedent PR (Fix graph widget tooltip overlap with header #4549), which also didn't add new stories

@google-cla

google-cla Bot commented Aug 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sileshidev-lab

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The traffic graph tooltip covers the header and navigation when the page scrolls

1 participant