Fix line chart tooltip stacking above the header and navigation on scroll - #13300
Open
sileshidev-lab wants to merge 2 commits into
Open
Fix line chart tooltip stacking above the header and navigation on scroll#13300sileshidev-lab wants to merge 2 commits into
sileshidev-lab wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13235 — clicking a point on the line chart in "Find out how your audience is growing" pins its tooltip open; scrolling then moves the tooltip up over the sticky header and navigation chips instead of behind them.
#4360 and #4496 fixed this same class of bug for the other dashboard charts (PieChart tooltip), via PR #4549, which added
z-index: 8;to the PieChart tooltip selector in three SCSS files. The.googlesitekit-chart--LineChart div.google-visualization-tooltipselector — sitting right next to the PieChart one in the same file — never got that treatment, so the line chart's tooltip (used by the "audience growing" widget'sUserCountGraph) was left with no z-index at all.Fix: add the same
z-index: 8;to the LineChart tooltip selector in_googlesitekit-chart.scss, matching the existing PieChart rule immediately below it. Confirmed the header's z-index (11, in_googlesitekit-header.scss) is higher, so this correctly puts the tooltip behind it.Verification
Loadedstory forDashboardAllTrafficWidgetGA4(which renders theUserCountGraphline chart with real data) that pinning a tooltip and inspecting the live rendered element showsz-index: 8actually applied — not just present in source, but compiled and loaded in the browsernpx stylelinton the changed file — clean