Feature/skills library gh issue by eugene-manuilov · Pull Request #13301 · google/site-kit-wp

eugene-manuilov · 2026-08-08T13:06:45Z

Summary

Related issue(s):

Resolves #

Relevant technical choices

PR Author Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 5.2 and PHP 7.4.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Run the code.
Ensure the acceptance criteria are satisfied.
Reassess the implementation with the IB.
Ensure no unrelated changes are included.
Ensure CI checks pass.
Check Storybook where applicable.
Ensure there is a QA Brief.
Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

Ensure the PR has the correct target branch.
Double-check that the PR is okay to be merged.
Ensure the corresponding issue has a ZenHub release assigned.
Add a changelog message to the issue.

…and commands.

…issues before coding.

…re to include it.

aaemnnosttv

Thanks @eugene-manuilov, this looks like a solid starting point. A few comments for you.

aaemnnosttv · 2026-08-12T21:25:33Z

+- **Omit what isn't needed.** Never write "no Storybook changes required" or similar — silence
+  says it.


Our guidance is opposite. None/no-changes should be explicit rather than just not-populated.

aaemnnosttv · 2026-08-12T21:33:13Z

+- **Work that isn't needed.** No "no Storybook changes required", "no migration needed", "no new
+  settings". Silence already says that.


aaemnnosttv · 2026-08-12T21:33:55Z

+state, what happens on success, what renders on error. Name the SCSS partial to create or extend
+and the index file to import it into.
+
+Do **not** include:


Also, references to code with plain text line numbers. Any reference should use a GH permalink.

aaemnnosttv · 2026-08-12T21:38:58Z

+
+## Step 4 — Lay out the issue
+
+Follow `.github/ISSUE_TEMPLATE/feature_request.md` exactly, including the moderator notice and


The template varies based on the type

aaemnnosttv · 2026-08-12T21:39:46Z

+```markdown
+# <title>
+
+## Feature Description
+
+<prose>
+
+---------------
+
+_Do not alter or remove anything below. The following sections will be managed by moderators only._
+
+## Acceptance criteria
+
+* <criterion>
+
+## Implementation Brief
+
+* [ ] <!-- One or more bullet points for how to technically implement the feature. Make sure to include changes to Storybook and visual regression tests where relevant. -->
+
+### Test Coverage
+
+* <!-- One or more bullet points for how to implement automated tests to verify the feature works. -->
+
+## QA Brief
+
+* <!-- One or more bullet points for how to test that the feature works as expected. -->
+
+## Changelog entry
+
+* <!-- One sentence summarizing the PR, to be used in the changelog. -->
+```


Why inline this here when we're referencing it above? Also, again, it varies based on which template.

aaemnnosttv · 2026-08-12T21:49:38Z

+
+The source is a design doc (a repo path or a hosted doc), requirements written in the user's message, or an existing issue (`!{gh issue view {{args}} --json title,body}`, or a local path the user supplies — never go looking for one).
+
+Two modes: a NEW issue gets both sections; an EXISTING issue that already has a Feature Description gets ONLY the criteria.


Again, not everything is a feature.
https://github.com/google/site-kit-wp/blob/develop/.github/ISSUE_TEMPLATE/bug_report.md

aaemnnosttv · 2026-08-12T22:05:56Z

These .gemini/commands don't seem to be needed, when I start Gemini CLI it warns about conflicts

Removing this directory causes those to no longer appear, and the commands are still available so it must be detecting the vendor-agnostic skills.

aaemnnosttv · 2026-08-12T22:07:36Z

@@ -0,0 +1,8 @@
+{
+	"enabledPlugins": {


Is this intended/necessary?

aaemnnosttv · 2026-08-12T22:07:46Z

+{
+	"enabledPlugins": {
+		"figma@claude-plugins-official": true,
+		"superpowers@claude-plugins-official": true,


This one seems like it doesn't belong

aaemnnosttv · 2026-08-12T22:10:10Z

+not create or edit a GitHub issue unless explicitly asked. (Claude Code exposes this as the
+`write-issue` skill; Gemini as `/write-issue`; Antigravity as the `/write-issue` workflow.)
+
+## Writing an implementation brief


I'd think these don't need a mention in this file since the skills should be loaded automatically and (even though it's not a lot) this will be included in every prompt. Otherwise, we should have a section for writing AC too, no?

…rary-gh-issue.

eugene-manuilov added 3 commits August 8, 2026 16:05

Add write-issue skill and workflow documentation for Site Kit issues.

3b4cbef

Add implementation brief and test coverage writing playbook, skills, …

c9d970f

…and commands.

Enhance implementation playbook with guidance on referencing related …

d25ba19

…issues before coding.

eugene-manuilov requested review from aaemnnosttv, techanvil and tofumatt August 8, 2026 13:07

Add settings.json for Claude plugin configuration and update .gitigno…

36018c2

…re to include it.

aaemnnosttv reviewed Aug 12, 2026

View reviewed changes

eugene-manuilov added 2 commits August 13, 2026 18:52

Merge remote-tracking branch 'origin/develop' into feature/skills-lib…

ff7eee4

…rary-gh-issue.

Enhance clarity and detail in issue writing guidelines.

5714fc2

Navigation Menu

Uh oh!

Feature/skills library gh issue - #13301

Feature/skills library gh issue#13301
eugene-manuilov wants to merge 6 commits into
developfrom
feature/skills-library-gh-issue

eugene-manuilov commented Aug 8, 2026

Uh oh!

aaemnnosttv left a comment

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

aaemnnosttv Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		- Omit what isn't needed. Never write "no Storybook changes required" or similar — silence
		says it.

		- Work that isn't needed. No "no Storybook changes required", "no migration needed", "no new
		settings". Silence already says that.


		## Step 4 — Lay out the issue

		Follow `.github/ISSUE_TEMPLATE/feature_request.md` exactly, including the moderator notice and


		The source is a design doc (a repo path or a hosted doc), requirements written in the user's message, or an existing issue (`!{gh issue view {{args}} --json title,body}`, or a local path the user supplies — never go looking for one).

		Two modes: a NEW issue gets both sections; an EXISTING issue that already has a Feature Description gets ONLY the criteria.

Uh oh!

Conversation

eugene-manuilov commented Aug 8, 2026

Summary

Relevant technical choices

PR Author Checklist

Code Reviewer Checklist

Merge Reviewer Checklist

Uh oh!

aaemnnosttv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants