Enhancement/13244 hub page - #13308
Open
ankitrox wants to merge 7 commits into
Open
Conversation
🎭 Playwright reports for 3c5fde8: 📚 Storybook for 3c5fde8: 📦 Build files for 3c5fde8:
|
|
Size Change: +23.4 kB (+0.7%) Total Size: 3.35 MB 📦 View Changed
ℹ️ View Unchanged
|
JakePT
requested changes
Aug 14, 2026
| VIEW_CONTEXT_USER_INPUT, | ||
| VIEW_CONTEXT_SPLASH, | ||
| VIEW_CONTEXT_SETTINGS, | ||
| VIEW_CONTEXT_FEATURE_DISCOVERY, |
Collaborator
There was a problem hiding this comment.
@ankitrox I believe this also needs to be added to
site-kit-wp/assets/js/util/is-site-kit-screen.test.js
Lines 39 to 57 in 3c5fde8
Comment on lines
+19
to
+22
| function FeatureDiscoveryApp() { | ||
| // @ToDO: Replace this with the actual Feature Discovery Hub app once it's implemented. | ||
| return <p>FDH App</p>; | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| function FeatureDiscoveryApp() { | |
| // @ToDO: Replace this with the actual Feature Discovery Hub app once it's implemented. | |
| return <p>FDH App</p>; | |
| } | |
| /** | |
| * External dependencies | |
| */ | |
| import { FC } from 'react'; | |
| const FeatureDiscoveryApp: FC = () => { | |
| // @TODO: Replace this with the actual Feature Discovery Hub app once it's implemented. | |
| return <p>FDH App</p>; | |
| }; |
I know it's only a placeholder but this is jut a couple of things flagged by agent review: Fixing @TODO and using FC as per docs/context/js/component-conventions.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s):
Screen, entrypoint & view context #13244Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist