Skip to content

Enhancement/12218 Composable Core Notifications Requirements - #13335

Merged
eugene-manuilov merged 8 commits into
developfrom
enhancement/12218-composable-notification-requirements
Aug 19, 2026
Merged

Enhancement/12218 Composable Core Notifications Requirements#13335
eugene-manuilov merged 8 commits into
developfrom
enhancement/12218-composable-notification-requirements

Conversation

@jimmymadon

@jimmymadon jimmymadon commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Related issue(s):

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

github-actions Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for a4490d7:

  • Storybook has been deleted.

📦 Build files for a4490d7:

  • Build files have been deleted.

🎭 Playwright reports for a4490d7:

  • Reports have been deleted.

@github-actions

github-actions Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Size Change: +1.04 kB (+0.03%)

Total Size: 3.33 MB

📦 View Changed
Filename Size Change
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 284 kB +1.04 kB (+0.37%)
ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 43.9 kB 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 7.03 kB 0 B
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 6.21 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 7.03 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 6.21 kB 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB 0 B
dist/assets/css/googlesitekit-admin-css-********************.min.css 74.6 kB 0 B
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.7 kB 0 B
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B 0 B
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 9.07 kB 0 B
dist/assets/js/46-********************.js 3.84 kB 0 B
dist/assets/js/65-********************.js 1.03 kB 0 B
dist/assets/js/187-********************.js 101 kB 0 B
dist/assets/js/308-********************.js 3 kB 0 B
dist/assets/js/315-********************.js 3.08 kB 0 B
dist/assets/js/397-********************.js 477 kB 0 B
dist/assets/js/403-********************.js 2.26 kB 0 B
dist/assets/js/509-********************.js 970 B 0 B
dist/assets/js/658-********************.js 52.7 kB 0 B
dist/assets/js/917-********************.js 2.41 kB 0 B
dist/assets/js/analytics-advanced-tracking-********************.js 404 B 0 B
dist/assets/js/googlesitekit-activation-********************.js 29 kB 0 B
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 66.7 kB 0 B
dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js 5.36 kB 0 B
dist/assets/js/googlesitekit-adminbar-********************.js 41.4 kB 0 B
dist/assets/js/googlesitekit-api-********************.js 8.04 kB 0 B
dist/assets/js/googlesitekit-block-tracking-********************.js 5.56 kB 0 B
dist/assets/js/googlesitekit-components-********************.js 6.28 kB 0 B
dist/assets/js/googlesitekit-consent-mode-********************.js 26 kB 0 B
dist/assets/js/googlesitekit-data-********************.js 1.83 kB 0 B
dist/assets/js/googlesitekit-datastore-forms-********************.js 7.21 kB 0 B
dist/assets/js/googlesitekit-datastore-location-********************.js 1.6 kB 0 B
dist/assets/js/googlesitekit-datastore-pdf-********************.js 1.22 kB 0 B
dist/assets/js/googlesitekit-datastore-site-********************.js 19.4 kB 0 B
dist/assets/js/googlesitekit-datastore-ui-********************.js 7.37 kB 0 B
dist/assets/js/googlesitekit-datastore-user-********************.js 23.8 kB 0 B
dist/assets/js/googlesitekit-entity-dashboard-********************.js 89.4 kB 0 B
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 2.35 kB 0 B
dist/assets/js/googlesitekit-events-provider-content-events-********************.js 43 B 0 B
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 1.12 kB 0 B
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 2.34 kB 0 B
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 2.3 kB 0 B
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 2.22 kB 0 B
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.08 kB 0 B
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 2.44 kB 0 B
dist/assets/js/googlesitekit-i18n-********************.js 4.43 kB 0 B
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 61.6 kB 0 B
dist/assets/js/googlesitekit-main-dashboard-********************.js 213 kB 0 B
dist/assets/js/googlesitekit-metric-selection-********************.js 65.3 kB 0 B
dist/assets/js/googlesitekit-modules-********************.js 28 kB 0 B
dist/assets/js/googlesitekit-modules-ads-********************.js 49.8 kB 0 B
dist/assets/js/googlesitekit-modules-adsense-********************.js 161 kB 0 B
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 25.3 kB 0 B
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 113 kB +679 B (+0.6%)
dist/assets/js/googlesitekit-modules-search-console-********************.js 75.5 kB 0 B
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 35.3 kB 0 B
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB 0 B
dist/assets/js/googlesitekit-notifications-********************.js 85.5 kB +483 B (+0.57%)
dist/assets/js/googlesitekit-polyfills-********************.js 227 B 0 B
dist/assets/js/googlesitekit-settings-********************.js 170 kB 0 B
dist/assets/js/googlesitekit-splash-********************.js 92.6 kB 0 B
dist/assets/js/googlesitekit-user-input-********************.js 57.6 kB 0 B
dist/assets/js/googlesitekit-vendor-********************.js 314 kB 0 B
dist/assets/js/googlesitekit-vendor-lazy-pdf-********************.js 21.6 kB 0 B
dist/assets/js/googlesitekit-widgets-********************.js 179 kB 0 B
dist/assets/js/googlesitekit-wp-dashboard-********************.js 69.2 kB 0 B
dist/assets/js/runtime-********************.js 1.95 kB 0 B
dist/assets/js/sign-in-with-google-********************.js 1.14 kB 0 B

compressed-size-action

zutigrm
zutigrm approved these changes Aug 19, 2026
View reviewed changes

@zutigrm zutigrm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugene-manuilov
eugene-manuilov merged commit 184e65b into develop Aug 19, 2026
34 of 37 checks passed
@eugene-manuilov
eugene-manuilov deleted the enhancement/12218-composable-notification-requirements branch August 19, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes
@zutigrm zutigrm zutigrm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor default core notifications to use new composable requirements

3 participants

@jimmymadon @eugene-manuilov @zutigrm