Enhancement/#13245 - Implement the core/feature-discovery datastore - #13336
Enhancement/#13245 - Implement the core/feature-discovery datastore#13336hussain-t wants to merge 14 commits into
core/feature-discovery datastore#13336Conversation
…tion and reducer.
…te, actions, controls, reducer, and selectors.
… other core stores.
📚 Storybook for b19fe47: 📦 Build files for b19fe47:
🎭 Playwright reports for b19fe47: |
JakePT
left a comment
There was a problem hiding this comment.
@hussain-t Added some feedback. Looks good, the main things are just taking the opportunity to implement some changes to the shape of features that were made while I was drafting #13247.
Also, the IB mentions:
The datastore will be registered in assets/js/googlesitekit-features.tsx added in #13244
But I don't think that's correct anymore. I think we'll probably be doing it in the separate entry point that #13247 adds, so we might want to update the IB. It might even be worth creating assets/js/googlesitekit-feature-discovery.ts and registering the store now. WDYT?
Thanks!
|
LGTM ✅ Note: I've verified that the VRT failure is unrelated to this PR. |
Summary
Related issue(s):
core/feature-discoverydatastore — registration & core selectors #13245Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist