Skip to content

Enhancement/#13245 - Implement the core/feature-discovery datastore - #13336

Open
hussain-t wants to merge 14 commits into
developfrom
enhancement/#13245-feature-discovery-datastore
Open

Enhancement/#13245 - Implement the core/feature-discovery datastore#13336
hussain-t wants to merge 14 commits into
developfrom
enhancement/#13245-feature-discovery-datastore

Conversation

@hussain-t

@hussain-t hussain-t commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Related issue(s):

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for b19fe47:

📦 Build files for b19fe47:

🎭 Playwright reports for b19fe47:

@JakePT JakePT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hussain-t Added some feedback. Looks good, the main things are just taking the opportunity to implement some changes to the shape of features that were made while I was drafting #13247.

Also, the IB mentions:

The datastore will be registered in assets/js/googlesitekit-features.tsx added in #13244

But I don't think that's correct anymore. I think we'll probably be doing it in the separate entry point that #13247 adds, so we might want to update the IB. It might even be worth creating assets/js/googlesitekit-feature-discovery.ts and registering the store now. WDYT?

Thanks!

Comment thread assets/js/googlesitekit/datastore/feature-discovery/selectors.ts Outdated
Comment thread assets/js/googlesitekit/datastore/feature-discovery/types.ts
Comment thread assets/js/googlesitekit/datastore/feature-discovery/types.ts
Comment thread assets/js/googlesitekit/datastore/feature-discovery/types.ts
Comment thread assets/js/googlesitekit/datastore/feature-discovery/types.ts Outdated
Comment thread assets/js/googlesitekit/datastore/feature-discovery/types.ts Outdated
Comment thread assets/js/googlesitekit/datastore/feature-discovery/constants.ts
@JakePT

JakePT commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

LGTM ✅

Note: I've verified that the VRT failure is unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the core/feature-discovery datastore — registration & core selectors

2 participants