fix(o11y): create noop tracer when artifact ID is not set#12307
Merged
fix(o11y): create noop tracer when artifact ID is not set#12307
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces validation logic to GoldenSignalsMetricsTracerFactory.withContext to ensure that the ApiTracerContext and its associated LibraryMetadata (specifically the artifact name) are present and valid before initializing the metrics recorder. It also adds corresponding unit tests. Review feedback suggests reordering the validation logic in GoldenSignalsMetricsTracerFactory to prevent partial state updates when validation fails. Additionally, it was pointed out that new tests for SpanTracerFactory were added without the necessary implementation updates to handle null or empty artifact names, which will likely cause test failures.
...atform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerFactoryTest.java
Show resolved
Hide resolved
...gax-java/gax/src/main/java/com/google/api/gax/tracing/GoldenSignalsMetricsTracerFactory.java
Show resolved
Hide resolved
blakeli0
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that fallback logic is consistently applied across observability tracers when the client library metadata—specifically the
artifactName—is omitted or invalid. If theartifactNameis missing, the factories will safely return a no-op (base) tracer.Key Changes
GoldenSignalsMetricsTracerFactory.withContext()to fallback toBaseApiTracerFactorywhen theApiTracerContextorartifactNameis missing, mirroringSpanTracerFactory.SpanTracerFactoryTestandGoldenSignalsMetricsTracerFactoryTestto explicitly validate tracer initialization under empty and null metadata conditions.