feat(gax): Implement trace context extraction and injection interceptors#12310
feat(gax): Implement trace context extraction and injection interceptors#12310westarle wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry trace propagation for both gRPC and HTTP/JSON callables. It adds new interceptors, GrpcTracePropagationInterceptor and HttpJsonTracePropagationInterceptor, which inject W3C trace context into request headers when OpenTelemetry is detected on the classpath. The PR also updates various callable implementations to wrap call executions within an ApiTracer.Scope and provides a concrete implementation of the inScope method in SpanTracer. Review feedback suggests adding debug-level logging when OpenTelemetry classes or methods are unavailable to improve observability during troubleshooting.
| // OpenTelemetry API is not available | ||
| isOpentelemetryAvailable = false; | ||
| } |
There was a problem hiding this comment.
Catching ClassNotFoundException and silently ignoring it can make debugging difficult if OpenTelemetry is expected to be available but isn't. Consider logging this exception at a debug level to provide more insight into why OpenTelemetry might not be found.
| } catch (NoSuchMethodError e) { | ||
| // Silently ignore if incompatible OpenTelemetry version | ||
| } |
There was a problem hiding this comment.
Similar to the ClassNotFoundException, silently ignoring NoSuchMethodError can obscure issues related to incompatible OpenTelemetry versions. Logging this at a debug level would be helpful for diagnosing potential runtime problems.
| isOpentelemetryAvailable = true; | ||
| } catch (ClassNotFoundException e) { | ||
| // OpenTelemetry API is not available |
There was a problem hiding this comment.
Catching ClassNotFoundException and silently ignoring it can make debugging difficult if OpenTelemetry is expected to be available but isn't. Consider logging this exception at a debug level to provide more insight into why OpenTelemetry might not be found.
| } catch (NoSuchMethodError e) { | ||
| // Silently ignore if incompatible OpenTelemetry version | ||
| } |
There was a problem hiding this comment.
Similar to the ClassNotFoundException, silently ignoring NoSuchMethodError can obscure issues related to incompatible OpenTelemetry versions. Logging this at a debug level would be helpful for diagnosing potential runtime problems.
westarle
force-pushed
the
trace-propagation-interceptors
branch
from
7dfaa9f to
65a795f
Compare
| @Override | ||
| public void start(ClientCall.Listener<RespT> responseListener, Metadata headers) { | ||
| try { | ||
| TextMapPropagator propagator = W3CTraceContextPropagator.getInstance(); |
There was a problem hiding this comment.
I think we can extract this logic to a common place such as SpanTracer.injectTracerId(). Call it in GrpcClientCalls and HttpJsonClientCallImpl where we have access to both ApiTracer and request headers.
This avoids creating interceptors for both transports and reuse similar logics.
2 participants
See main...westarle:google-cloud-java:trace-propagation-integration-test for the end-to-end integration test.