feat(observability): implement url.domain attribute#12316
Open
diegomarquezp wants to merge 5 commits intomainfrom
Open
feat(observability): implement url.domain attribute#12316diegomarquezp wants to merge 5 commits intomainfrom
diegomarquezp wants to merge 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the urlDomain attribute for observability across all transport types by updating ClientContext to derive it from the service name and universe domain. It also modifies ApiTracerContext to include this attribute in both attempt and metrics attributes and adds relevant unit and integration tests. A review comment identifies a potential issue where a null universe domain could result in a malformed string like "serviceName.null", suggesting a check for both values before concatenation.
sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Mar 31, 2026
sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request implements the
url.domainobservability attribute in thegax-javalibrary. This attribute records the 'nominal' domain where the request is intended to go (e.g.,service.googleapis.com), distinct fromserver.addresswhich reflects the actual destination (which could belocalhostor a proxy).The attribute is now recorded in both attempt-level spans and metrics for both gRPC and HTTP/JSON transports, provided that the
serviceNameis available in theClientContext.